Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the behaviour of combining @data and @singleton #3

Open
rayanht opened this issue Feb 21, 2021 · 1 comment
Open

Fix the behaviour of combining @data and @singleton #3

rayanht opened this issue Feb 21, 2021 · 1 comment

Comments

@rayanht
Copy link
Owner

rayanht commented Feb 21, 2021

Describe the bug

When combining @singleton with @data, @singleton should come before @data. Combining them the other way around will work in most cases but is not thoroughly tested and relies on assumptions that might not hold.

Expected behavior
There should be a single correct way of emulating this behaviour. We should raise an immediately actionable error when they are combined in a way that isn't guaranteed to function.
@rayanht rayanht changed the title Clarify the expected behaviour of combining @data and @singleton Fix the behaviour of combining @data and @singleton Feb 21, 2021
@rayanht rayanht linked a pull request Feb 21, 2021 that will close this issue
Feature/performance counters #4
Merged
@rayanht rayanht closed this as completed Feb 21, 2021
@rayanht rayanht removed a link to a pull request Feb 21, 2021
Feature/performance counters #4
Merged
@rayanht rayanht reopened this Feb 21, 2021
@suneel944
Copy link

why this has been reopened? any issue persisting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rayanht @suneel944