From 8c18e44f71110d969e87cacda03223d308c1359c Mon Sep 17 00:00:00 2001
From: Spencer Peterson <spencerjp@google.com>
Date: Fri, 3 Jan 2025 15:17:04 -0800
Subject: [PATCH] Address review comments #1

- Suggest disabling AOF on gcsfuse, s3
- Update redis version
- Don't provide a default storageClass
---
 .../best-practice/gcs-fault-tolerance-persistent-redis.md | 8 ++++----
 .../config/samples/ray-cluster.persistent-redis.yaml      | 5 +++--
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/docs/best-practice/gcs-fault-tolerance-persistent-redis.md b/docs/best-practice/gcs-fault-tolerance-persistent-redis.md
index bbfc2a5b1a7..6374654497a 100644
--- a/docs/best-practice/gcs-fault-tolerance-persistent-redis.md
+++ b/docs/best-practice/gcs-fault-tolerance-persistent-redis.md
@@ -31,9 +31,9 @@ replica) Redis, so clustering is omitted.
 
 ## Persistent storage
 
-Specialty storage volumes (like Google Cloud Storage FUSE or S3) are not
-recommended because append operations are not supported, which Redis uses to
-efficiently write its Append Only File (AOF) log.
+Specialty storage volumes (like Google Cloud Storage FUSE or S3) do not support
+append operations, which Redis uses to efficiently write its Append Only File
+(AOF) log. When using using these options, it is recommended to disable AOF.
 
 With GCP GKE and Azure AKS, the default storage classes are [persistent
 disks](https://cloud.google.com/kubernetes-engine/docs/concepts/persistent-volumes)
@@ -97,7 +97,7 @@ auto-aof-rewrite-min-size 64mb
 ```
 
 You can view the full reference for 5.0.8
-[here](https://raw.githubusercontent.com/redis/redis/refs/tags/5.0.8/redis.conf).
+[here](https://raw.githubusercontent.com/redis/redis/refs/tags/7.4.0/redis.conf).
 
 
 If your job is generally idempotent and can resume from several minutes of state
diff --git a/ray-operator/config/samples/ray-cluster.persistent-redis.yaml b/ray-operator/config/samples/ray-cluster.persistent-redis.yaml
index 185f6ef3f7c..038fb255c66 100644
--- a/ray-operator/config/samples/ray-cluster.persistent-redis.yaml
+++ b/ray-operator/config/samples/ray-cluster.persistent-redis.yaml
@@ -140,7 +140,8 @@ spec:
   resources:
     requests:
       storage: 8Gi
-  storageClassName: standard-rwo
+  # choose a storageClassName provided by your Kubernetes:
+  #storageClassName: standard-rwo
 ---
 apiVersion: apps/v1
 kind: StatefulSet
@@ -160,7 +161,7 @@ spec:
     spec:
       containers:
         - name: redis
-          image: redis:5.0.8
+          image: redis:7.4.0
           command:
             - "sh"
             - "-c"