Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical Error while editing content in contact #48

Open
rtwent opened this issue Nov 12, 2017 · 0 comments
Open

Logical Error while editing content in contact #48

rtwent opened this issue Nov 12, 2017 · 0 comments

Comments

@rtwent
Copy link

rtwent commented Nov 12, 2017

Hi thank You very much for the extension.
Please check in rapidweb\googlecontacts\factories\ContactFactory in method submitUpdates - there is no line for editing content of the contact. The xml that we get from google is:
`

<entry xmlns="http://www.w3.org/2005/Atom" mlns:batch="http://schemas.google.com/gdata/batch" mlns:gContact="http://schemas.google.com/contact/2008" xmlns:gd="http://schemas.google.com/g/2005">
	<id>http://www.google.com/m8/feeds/contacts/someaccount/base/f22c9988edd3ec1</id>
	<updated>2017-11-12T16:24:17.414Z</updated> 
	<category scheme="http://schemas.google.com/g/2005#kind" term="http://schemas.google.com/contact/2008#contact"/>
	<title type="text">Test Buyer (127724)</title>
	<content type="text">Test description</content> 
	<link rel="http://schemas.google.com/contacts/2008/rel#edit-photo" type="image/*" 				href="https://www.google.com/m8/feeds/photos/media/someaccount/f22c9988edd3ec1/1B2M2Y8AsgTpgAmY7PhCfg"/> <link rel="self" type="application/atom+xml" href="https://www.google.com/m8/feeds/contacts/someaccount/full/f22c9988edd3ec1"/> 
	<link rel="edit" type="application/atom+xml" href="https://www.google.com/m8/feeds/contacts/someaccount/full/f22c9988edd3ec1/1510503857414002"/>
	<gd:email rel="http://schemas.google.com/g/2005#work" address="[email protected]"/> 
	<gd:phoneNumber rel="http://schemas.google.com/g/2005#work" uri="tel:+somephone">+somephone</gd:phoneNumber> 

`
And the line of code
$contactGDNodes = $xmlContactsEntry->children('http://schemas.google.com/g/2005');
will return only gd:email and gd:phoneNumber. You made special line for title, but forget about content:
$xmlContactsEntry->title = $updatedContact->name;
Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant