Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

allow users to choose shm allocation method for chunked/continous host memory #187

Merged
merged 3 commits into from
Jun 18, 2024
Merged

allow users to choose shm allocation method for chunked/continous host memory #187

merged 3 commits into from
Jun 18, 2024

Conversation

linhu-nv
Copy link
Contributor

  1. The default shm option is still SYSTEMV, but users can choose POSIX API through system env using export WG_USE_POSIX_SHM=1.
  2. unlink shm files immediately after shm_open to avoid leftover memory in /dev/shm in case of a wholegraph crash.

chuangz0
chuangz0 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@chuangz0 chuangz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@chuangz0 chuangz0 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 18, 2024
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 4ee62ba into rapidsai:branch-24.08 Jun 18, 2024
49 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@chuangz0 chuangz0 chuangz0 approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linhu-nv @BradReesWork @chuangz0