Add retry mechanism to test_ucx_config_w_env_var
#377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a retry mechanism to ensure the Dask scheduler will bind to a free port and retry if the port is not free. We still use `distributed.utils.open_port` to attempt first, but that port seems not to be realiable for UCX, in which cases `UCXXBusyError` is raised, we capture that, increment the port and retry.
pentschev
added
bug
madsbk
approved these changes
Feb 25, 2025
python/distributed-ucxx/distributed_ucxx/tests/test_ucxx_config.py
Outdated
Show resolved
Hide resolved
python/distributed-ucxx/distributed_ucxx/tests/test_ucxx_config.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mads R. B. Kristensen <[email protected]>
|
Thanks @madsbk , I pushed the changes you suggested and will merge when CI passes. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a retry mechanism to ensure the Dask scheduler will bind to a free port and retry if the port is not free. We still use
distributed.utils.open_portto attempt first, but that port seems not to be realiable for UCX, in which casesUCXXBusyErroris raised, we capture that, increment the port and retry.This test fails seldom in CI for the reason stated above.