Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telemetry #321

Merged
merged 5 commits into from
Feb 12, 2025
Merged

add telemetry #321

merged 5 commits into from
Feb 12, 2025

Conversation

msarahan
Copy link
Contributor

Adds telemetry that will send timing information about each step in the build process to a time series database, for later viewing and analytics.

Tracking issue: https://github.com/rapidsai/build-infra/issues/139

This is not expected to work right now. We are in flux regarding a time series database that is in the same private network as the build machines. @ajschmidt8 has restricted the mTLS certificates that are used for the current database to specific repos. Either he will enable those here, or we'll make the switch to the new server, and then this mechanism should work.

@msarahan msarahan added improvement Improves an existing functionality non-breaking Introduces a non-breaking change Needs build-infra Requires input from the build infrastructure team labels Nov 14, 2024
@msarahan msarahan changed the base branch from branch-0.41 to branch-0.43 February 4, 2025 22:45
Copy link

copy-pr-bot bot commented Feb 4, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@msarahan
Copy link
Contributor Author

msarahan commented Feb 4, 2025

/ok to test

@msarahan msarahan marked this pull request as ready for review February 6, 2025 15:48
@msarahan msarahan requested a review from a team as a code owner February 6, 2025 15:48
@msarahan msarahan requested a review from jameslamb February 6, 2025 15:48
@msarahan
Copy link
Contributor Author

msarahan commented Feb 8, 2025

/merge

@msarahan
Copy link
Contributor Author

msarahan commented Feb 8, 2025

build failure seems like a problem with cuda or rmm in the devcontainer:

[1/51] /usr/bin/sccache /home/coder/.conda/envs/rapids/bin/x86_64-conda-linux-gnu-c++ -DLIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_DISABLE_ABI_NAMESPACE -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -DTHRUST_IGNORE_ABI_NAMESPACE_ERROR -DUCXX_ENABLE_RMM -Ducxx_EXPORTS -I/home/coder/ucxx/cpp/include -I/home/coder/ucxx/cpp/src -I/home/coder/.conda/envs/rapids/include/rapids -I/home/coder/.conda/envs/rapids/include/rapids/libcudacxx -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/coder/.conda/envs/rapids/include -O3 -DNDEBUG -std=gnu++17 -fPIC -Wall -Wattributes -Werror -Wextra -Wsign-conversion -Wno-missing-field-initializers -pthread -MD -MT CMakeFiles/ucxx.dir/src/buffer.cpp.o -MF CMakeFiles/ucxx.dir/src/buffer.cpp.o.d -o CMakeFiles/ucxx.dir/src/buffer.cpp.o -c /home/coder/ucxx/cpp/src/buffer.cpp
FAILED: CMakeFiles/ucxx.dir/src/buffer.cpp.o 
/usr/bin/sccache /home/coder/.conda/envs/rapids/bin/x86_64-conda-linux-gnu-c++ -DLIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_DISABLE_ABI_NAMESPACE -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -DTHRUST_IGNORE_ABI_NAMESPACE_ERROR -DUCXX_ENABLE_RMM -Ducxx_EXPORTS -I/home/coder/ucxx/cpp/include -I/home/coder/ucxx/cpp/src -I/home/coder/.conda/envs/rapids/include/rapids -I/home/coder/.conda/envs/rapids/include/rapids/libcudacxx -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O2 -ffunction-sections -pipe -isystem /home/coder/.conda/envs/rapids/include -O3 -DNDEBUG -std=gnu++17 -fPIC -Wall -Wattributes -Werror -Wextra -Wsign-conversion -Wno-missing-field-initializers -pthread -MD -MT CMakeFiles/ucxx.dir/src/buffer.cpp.o -MF CMakeFiles/ucxx.dir/src/buffer.cpp.o.d -o CMakeFiles/ucxx.dir/src/buffer.cpp.o -c /home/coder/ucxx/cpp/src/buffer.cpp
In file included from /home/coder/.conda/envs/rapids/include/rmm/cuda_device.hpp:19,
                 from /home/coder/.conda/envs/rapids/include/rmm/device_buffer.hpp:18,
                 from /home/coder/ucxx/cpp/src/buffer.cpp:12:
/home/coder/.conda/envs/rapids/include/rmm/detail/error.hpp:21:10: fatal error: cuda_runtime_api.h: No such file or directory
   21 | #include <cuda_runtime_api.h>
      |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

@msarahan
Copy link
Contributor Author

/ok to test

@rapids-bot rapids-bot bot merged commit 35d4903 into rapidsai:branch-0.43 Feb 12, 2025
70 checks passed
@msarahan msarahan deleted the add-telemetry branch February 12, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality Needs build-infra Requires input from the build infrastructure team non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants