-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure dask_cuda.__git_commit__ is populated #1453
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
Here's a run from a previous PR: https://github.com/rapidsai/dask-cuda/actions/runs/13332958081/job/37252862171. There's no The build output from this PR is at https://github.com/rapidsai/dask-cuda/actions/runs/13439129864/job/37548802662?pr=1453#step:11. There's a warning about no files matching Anyway, what we really care about is that the built wheel has it, and it looks like it does:
|
Yeah thank you for looking carefully at that! I think I can explain what's happening there. The key point is this from the
The first pass through, creating an sdist, is what emits these warnings:
That happens around here in And at that point, that But then later on, during wheel-building, those rules in the manifest are executed one at a time.
And by there, the file exists and gets packaged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
/merge |
Installing
dask-cuda
like this:pip install \ --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/ \ 'dask-cuda==25.4.*,>=0.0.0a0'
The
__git_commit__
attribute on the main module isn't populated:python -c "import dask_cuda; print(dask_cuda.__git_commit__)"
The way this should work is that
rapids-build-backend
writes a filedask_cuda/GIT_COMMIT
which is then read by this code:dask-cuda/dask_cuda/_version.py
Lines 20 to 28 in 412ef58
I think that what's happening here is this:
rapids-build-backend
is writing that filesetuptools
+ aMANIFEST.in
, and thatMANIFEST.in
does not include that fileThis proposes the following:
GIT_COMMIT
toMANIFEST.in
Notes for Reviewers
Helpful reference for this... "Controlling files in the distribution" from the
setuptools
docs: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html