-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test with CUDA 12.8.0 #649
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test failed with what looks like a network error downloading some test data from GitHub.
cux_df = <cuxfilter.dataframe.DataFrame object at 0x7f46223787f0>
@pytest.mark.parametrize("cux_df", cux_dfs)
def test_init(self, cux_df):
> choropleth3d_chart = charts.choropleth(
x="states",
color_column="val",
elevation_column="val_t",
color_aggregate_fn="mean",
elevation_aggregate_fn="count",
add_interaction=False,
elevation_factor=100000,
geoJSONSource=(
"https://raw.githubusercontent.com/loganpowell/census-geojson"
"/master/GeoJSON/5m/2018/state.json"
),
geoJSONProperty="STATEFP",
map_style="testMap",
)
...
/opt/conda/envs/test/lib/python3.10/ssl.py:1375: ConnectionResetError
I checked and the file really is there, so I guess this was just something temporary (https://github.com/rapidsai/cuxfilter/actions/runs/13014410941/job/36301473875?pr=649).
Restarted CI for you. I also opened #650 documenting the work to try to factor out that download.
Left one other suggestion about a few more updates that were missed in docs.
Approving, assuming those docs updates will be made. I don't need to re-review.
/merge |
This PR uses CUDA 12.8.0 to build and test.
xref: rapidsai/build-planning#139