From c0f2271c4a17ac79c2c184799f0697d50218786e Mon Sep 17 00:00:00 2001 From: James Lamb Date: Wed, 13 Nov 2024 11:39:43 -0600 Subject: [PATCH 1/3] enforce wheel size limits, README formatting in CI --- ci/build_wheel.sh | 2 ++ ci/validate_wheel.sh | 18 ++++++++++++++++++ python/pyproject.toml | 8 ++++++++ 3 files changed, 28 insertions(+) create mode 100755 ci/validate_wheel.sh diff --git a/ci/build_wheel.sh b/ci/build_wheel.sh index d1be578b..f9d5bac3 100755 --- a/ci/build_wheel.sh +++ b/ci/build_wheel.sh @@ -16,4 +16,6 @@ cd "${package_dir}" python -m pip wheel . -w dist -v --no-deps --disable-pip-version-check +../../ci/validate_wheel.sh dist + RAPIDS_PY_WHEEL_NAME="${package_name}_${RAPIDS_PY_CUDA_SUFFIX}" RAPIDS_PY_WHEEL_PURE="1" rapids-upload-wheels-to-s3 dist diff --git a/ci/validate_wheel.sh b/ci/validate_wheel.sh new file mode 100755 index 00000000..60a80fce --- /dev/null +++ b/ci/validate_wheel.sh @@ -0,0 +1,18 @@ +#!/bin/bash +# Copyright (c) 2024, NVIDIA CORPORATION. + +set -euo pipefail + +wheel_dir_relative_path=$1 + +rapids-logger "validate packages with 'pydistcheck'" + +pydistcheck \ + --inspect \ + "$(echo ${wheel_dir_relative_path}/*.whl)" + +rapids-logger "validate packages with 'twine'" + +twine check \ + --strict \ + "$(echo ${wheel_dir_relative_path}/*.whl)" diff --git a/python/pyproject.toml b/python/pyproject.toml index a5f7159c..e2c1d374 100644 --- a/python/pyproject.toml +++ b/python/pyproject.toml @@ -69,6 +69,14 @@ license-files = ["LICENSE"] [tool.setuptools.dynamic] version = {file = "cuxfilter/VERSION"} +[tool.pydistcheck] +select = [ + "distro-too-large-compressed", +] + +# PyPI limit is 100 MiB, fail CI before we get too close to that +max_allowed_size_compressed = '75M' + [tool.pytest.ini_options] filterwarnings = [ "error::FutureWarning", From ddcae3ba1fa8218b0c2bf6120a82e6c948ed52b7 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Wed, 13 Nov 2024 13:44:21 -0600 Subject: [PATCH 2/3] fix path --- ci/build_wheel.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/build_wheel.sh b/ci/build_wheel.sh index f9d5bac3..4fb8091c 100755 --- a/ci/build_wheel.sh +++ b/ci/build_wheel.sh @@ -16,6 +16,6 @@ cd "${package_dir}" python -m pip wheel . -w dist -v --no-deps --disable-pip-version-check -../../ci/validate_wheel.sh dist +../ci/validate_wheel.sh dist RAPIDS_PY_WHEEL_NAME="${package_name}_${RAPIDS_PY_CUDA_SUFFIX}" RAPIDS_PY_WHEEL_PURE="1" rapids-upload-wheels-to-s3 dist From 685f5f82fd1871e571aac8e931f79be1d7fcb05f Mon Sep 17 00:00:00 2001 From: James Lamb Date: Wed, 13 Nov 2024 21:33:10 -0600 Subject: [PATCH 3/3] empty commit to re-trigger all CI