Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure notebook-testing script fails when notebooks fail #1424

Merged
merged 10 commits into from
Aug 13, 2024
Merged

ensure notebook-testing script fails when notebooks fail #1424

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bbb8941
ensure notebook-testing script fails when notebooks fail
jameslamb Aug 1, 2024
b8994bf
skip ZipCodes_Stops_PIP_cuSpatial.ipynb
jameslamb Aug 1, 2024
7ca2cd7
fix error in nyc_taxi_years_correlation notebook
jameslamb Aug 2, 2024
96ff6b8
geometry_offset (singular)
jameslamb Aug 2, 2024
3c699d0
Merge branch 'branch-24.10' into ci/notebook-script
jameslamb Aug 7, 2024
f1a08bb
Update ci/test_notebooks.sh
jameslamb Aug 7, 2024
5194b64
Merge branch 'branch-24.10' into ci/notebook-script
bdice Aug 9, 2024
7aea38a
Merge branch 'branch-24.10' into ci/notebook-script
jameslamb Aug 12, 2024
0f0f184
Merge branch 'branch-24.10' into ci/notebook-script
jameslamb Aug 12, 2024
0e3f6ae
Merge branch 'branch-24.10' into ci/notebook-script
jameslamb Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/test_notebooks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
# Copyright (c) 2020-2024, NVIDIA CORPORATION.

set -euo pipefail
set -eEuo pipefail

. /opt/conda/etc/profile.d/conda.sh

Expand Down Expand Up @@ -29,7 +29,7 @@ NBTEST="$(realpath "$(dirname "$0")/utils/nbtest.sh")"

# Add notebooks that should be skipped here
# (space-separated list of filenames without paths)
SKIPNBS="binary_predicates.ipynb cuproj_benchmark.ipynb"
SKIPNBS="binary_predicates.ipynb cuproj_benchmark.ipynb ZipCodes_Stops_PiP_cuSpatial.ipynb"

EXITCODE=0
trap "EXITCODE=1" ERR
Expand Down
4 changes: 2 additions & 2 deletions notebooks/nyc_taxi_years_correlation.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@
"taxi_zone_rings = cuspatial.GeoSeries.from_polygons_xy(\n",
" polygons_xy=taxi_zones.polygons.xy,\n",
" ring_offset=taxi_zones.polygons.ring_offset,\n",
" part_offsets=taxi_zones.polygons.part_offset,\n",
" geometry_offsets=cudf.Series(range(len(taxi_zones.polygons.part_offset)))\n",
" part_offset=taxi_zones.polygons.part_offset,\n",
" geometry_offset=cudf.Series(range(len(taxi_zones.polygons.part_offset)))\n",
")"
]
},
Expand Down
Loading