Skip to content

Commit

Permalink
Remove unused masked keyword in column_empty (#1496)
Browse files Browse the repository at this point in the history
rapidsai/cudf#16715 makes size 0 cudf columns have no mask buffer which I think aligns with the intention in `empty_geometry_column`. Additionally, it makes the `masked` keyword unnecessary and unused so removing it here.

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Michael Wang (https://github.com/isVoid)

URL: #1496
  • Loading branch information
mroeschke authored Dec 4, 2024
1 parent 628ebcf commit c0fe437
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions python/cuspatial/cuspatial/utils/column_utils.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2020-2023, NVIDIA CORPORATION.
# Copyright (c) 2020-2024, NVIDIA CORPORATION.

from typing import TypeVar

Expand Down Expand Up @@ -136,10 +136,10 @@ def has_multipolygons(gs: GeoSeries):
def empty_geometry_column(feature: Feature_Enum, base_type):
"""Return a geometry column of type `feature`. Length is 0."""
if feature == Feature_Enum.POINT:
return column_empty(0, point_dtype(base_type), masked=False)
return column_empty(0, point_dtype(base_type))
elif feature == Feature_Enum.MULTIPOINT:
return column_empty(0, multipoint_dtype(base_type), masked=False)
return column_empty(0, multipoint_dtype(base_type))
elif feature == Feature_Enum.LINESTRING:
return column_empty(0, linestring_dtype(base_type), masked=False)
return column_empty(0, linestring_dtype(base_type))
elif feature == Feature_Enum.POLYGON:
return column_empty(0, polygon_dtype(base_type), masked=False)
return column_empty(0, polygon_dtype(base_type))

0 comments on commit c0fe437

Please sign in to comment.