Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace or drop pytest-lazy-fixture #755

Closed
jakirkham opened this issue Aug 2, 2024 · 4 comments
Closed

Replace or drop pytest-lazy-fixture #755

jakirkham opened this issue Aug 2, 2024 · 4 comments
Milestone
v24.10.00

Comments

@jakirkham
Copy link
Member

After some recent unrelated testing work, we learned that pytest-lazy-fixture is incompatible with pytest version 8.0.0 or newer. This has been the case for 6 months now as this issue notes: TvoroG/pytest-lazy-fixture#65

Given this we may want to drop or replace this dependency

One option on the replacement side is pytest-lazy-fixtures, which it looks straightforward to switch to
@jakirkham
Copy link
Member Author

cc @grlee77

@grlee77
Copy link
Contributor

grlee77 commented Aug 2, 2024 •
edited
Loading

It is not used for cucim.skimage or cucim.core test cases. but is used for some I/O related ones under python/cucim/tests/. It is imported here in a helper module loaded by the python/cucim/tests/conftest.py.

cc @gigony as original author of those test fixtures

@gigony
Copy link
Contributor

gigony commented Aug 5, 2024 •
edited
Loading

Thanks @jakirkham and @grlee77 !
Let me check if I can replace it with pytest-lazy-fixtures.

gigony added a commit to gigony/cucim that referenced this issue Aug 5, 2024
@gigony
Switch to pytest-lazy-fixtures
ec08088 
Remove the `pytest-lazy-fixture` plugin and use the replacement `pytest-lazy-fixtures` package instead.

Address  rapidsai#755

Signed-off-by: Gigon Bae <[email protected]>
gigony added a commit to gigony/cucim that referenced this issue Aug 5, 2024
@gigony
Switch to pytest-lazy-fixtures
31595a8 
Remove the `pytest-lazy-fixture` plugin and use the replacement `pytest-lazy-fixtures` package instead.

Address  rapidsai#755

Signed-off-by: Gigon Bae <[email protected]>
@gigony gigony mentioned this issue Aug 5, 2024
Merged
gigony added a commit to gigony/cucim that referenced this issue Aug 5, 2024
@gigony
Switch to pytest-lazy-fixtures
8a0863e 
Remove the `pytest-lazy-fixture` plugin and use the replacement `pytest-lazy-fixtures` package instead.

Address  rapidsai#755

Signed-off-by: Gigon Bae <[email protected]>
gigony added a commit to gigony/cucim that referenced this issue Aug 20, 2024
@gigony
Switch to pytest-lazy-fixtures
48668ec 
Remove the `pytest-lazy-fixture` plugin and use the replacement `pytest-lazy-fixtures` package instead.

Address  rapidsai#755

Signed-off-by: Gigon Bae <[email protected]>
rapids-bot bot pushed a commit that referenced this issue Aug 20, 2024
@gigony
Switch to pytest-lazy-fixtures (#756)
ef99071 
Remove the `pytest-lazy-fixture` plugin and use the replacement `pytest-lazy-fixtures` package instead.

Address  #755

Authors:
  - Gigon Bae (https://github.com/gigony)

Approvers:
  - https://github.com/jakirkham

URL: #756
@jakirkham jakirkham added this to the v24.10.00 milestone Aug 23, 2024
@jakirkham
Copy link
Member Author

This was done in PR: #756

Thanks Gigon! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v24.10.00
Development

No branches or pull requests
3 participants
@gigony @jakirkham @grlee77