Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate wheel on CI #664

Closed
jakirkham opened this issue Dec 12, 2023 · 0 comments · Fixed by #680
Closed

Validate wheel on CI #664

jakirkham opened this issue Dec 12, 2023 · 0 comments · Fixed by #680
Labels
maintenance
Milestone
v24.02.00

Comments

@jakirkham
Copy link
Member

Recently we had to add a workaround to mark a wheel as non-pure ( #643 ). It would be good to add some checks in CI to confirm that the wheel is being marked correctly. At a minimum this could just validate the wheel file name.
@jakirkham jakirkham added this to the v24.02.00 milestone Dec 12, 2023
@jakirkham jakirkham mentioned this issue Jan 24, 2024
Merged
@rapids-bot rapids-bot bot closed this as completed in #680 Jan 24, 2024
rapids-bot bot pushed a commit that referenced this issue Jan 24, 2024
@jakirkham
Fix CI (pt. 2) (#680)
bf5a6f7 
Fixes #664

* Pin RAPIDS packages to intended version (this helped find the `openslide` / `openslide-python` issue)
* Validate wheels have the expected name (no `none` in them like with pure wheels)

Authors:
  - https://github.com/jakirkham

Approvers:
  - Gregory Lee (https://github.com/grlee77)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v24.02.00
Development

Successfully merging a pull request may close this issue.

Fix CI (pt. 2) jakirkham/cucim
1 participant
@jakirkham