Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where can I found ans2cat.json? #1

Open
beckybai opened this issue Apr 2, 2019 · 6 comments
Open

Where can I found ans2cat.json? #1

beckybai opened this issue Apr 2, 2019 · 6 comments

Comments

@beckybai
Copy link

beckybai commented Apr 2, 2019

Hi, Ranjay

Thanks for releasing the code.

The input parameters of "iq/utils/store_dataset.py" includes a path to the processed "ans2cat.json file". There isn't a processed code for generating this file. Can it be done by exchanging the position of key-value pair in here?

Thanks
Becky

@beckybai
Copy link
Author

beckybai commented Apr 3, 2019

Some other questions:

  1. utils/init.py
    from .nlg_eval.nlgeval import NLGEval
    No file called "nlg_eval". This function is very important for the evaluation.

  2. train_iq.py
    data_loader = get_loader(args.dataset, transform, ...
    No get_vae_loader. Should it be get_loader?

  3. train_iq.py
    train_weights = json.load(open(args.train_dataset_weights))
    Where can we get "train-dataset-weights"?

  4. iq.py
    self.decoder = DecoderRNN(vocab_size, max_len, hidden_size, sos_id=sos_id, eos_id=eos_id, n_layers=num_layers, rnn_cell=rnn_cell, input_dropout_p=input_dropout_p, dropout_p=dropout_p, # use_attention=use_attention, embedding=embedding)
    DecoderRNN doesn't have use_attention keywork argument.

Thanks!

@tobytyx
Copy link

tobytyx commented Apr 18, 2019

Hi, Ranjay

Thanks for releasing the code.

The input parameters of "iq/utils/store_dataset.py" includes a path to the processed "ans2cat.json file". There isn't a processed code for generating this file. Can it be done by exchanging the position of key-value pair in here?

Thanks
Becky

Hi beckybai
I'm facing the same question. If you solve the question, could you tell me the solution?
Thanks a lot!

@beckybai
Copy link
Author

Hi, Ranjay
Thanks for releasing the code.
The input parameters of "iq/utils/store_dataset.py" includes a path to the processed "ans2cat.json file". There isn't a processed code for generating this file. Can it be done by exchanging the position of key-value pair in here?
Thanks
Becky

Hi beckybai
I'm facing the same question. If you solve the question, could you tell me the solution?
Thanks a lot!

I didn't find any solution.

@jennifererwangg
Copy link

Hi @beckybai and @tobytyx, I solved this issue by substituting cat2ans.json with iq_dataset.json and made some changes in store_dataset.py. You can see the changes that I made in my forked repo. Similarly, although I haven't tried it, I think you could also reverse the key and value pairs in iq_dataset.json to generate cat2ans.json.

I also couldn't find the train_datasets_weight.json file. Have you guys found a solution? Thanks!

@ljsun
Copy link

ljsun commented Sep 30, 2019

Hi, Ranjay

Thanks for releasing the code.

The input parameters of "iq/utils/store_dataset.py" includes a path to the processed "ans2cat.json file". There isn't a processed code for generating this file. Can it be done by exchanging the position of key-value pair in here?

Thanks
Becky

Hi beckybai
I'm facing the same question. If you solve the question, could you tell me the solution?
Thanks a lot!

@nanguoshun
Copy link

I am facing the same issues too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants