Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private key in seed format for ML-KEM, ML-DSA, and SLH-DSA ? #4327

Closed
falko-strenzke opened this issue Aug 26, 2024 · 6 comments
Closed

private key in seed format for ML-KEM, ML-DSA, and SLH-DSA ? #4327

falko-strenzke opened this issue Aug 26, 2024 · 6 comments

Comments

@falko-strenzke
Copy link
Collaborator

Are there any plans to add the seed format for serialization of ML-KEM, ML-DSA, and SLH-DSA private keys? The discussion on the LAMPS list regarding the decision is ongoing and doesn't seem to be decided yet.

@reneme
Copy link
Collaborator

reneme commented Aug 26, 2024

There's some discussion in the ML-KEM PR: #3893 (comment)

Generally, I'm fine with adding the seed expansion to the public API as well as not exposing the reading of expanded keys, if there's a quorum in the community.

Obviously, @randombit get's to have the final say on that.

@mouse07410
Copy link
Contributor

My vote:

  1. Support using seed as a way to provide private key (maybe as the main way);
  2. Still keep visible acres to expanded key.

@randombit
Copy link
Owner

No strong opinion here. Using the seed as the canonical secret key encoding does seem better overall. Main thing I’d like to avoid, if possible, is us ending up having to support several different key formats which are mutually unintelligable with other implementations. [This is probably inenvitable…]

@reneme
Copy link
Collaborator

reneme commented Sep 13, 2024

For the record: I changed the ML-KEM pull request to use the seeds exclusively.

@reneme reneme mentioned this issue Sep 16, 2024
18 tasks
@reneme
Copy link
Collaborator

reneme commented Sep 17, 2024

For the record: I changed the ML-DSA pull request to use the seed exclusively.

@reneme
Copy link
Collaborator

reneme commented Oct 15, 2024

With #3893 and #4270 merged we're now supporting the seed-based encoding for the private keys exclusively. I wouldn't rule out that we introduce support for the expanded format in case the need arises. But for the time being the expanded format is explicitly not supported for ML-KEM and ML-DSA.

@reneme reneme closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants