Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workload): disable access to unreturned data attributes in data method #12998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ly5156
Copy link
Contributor

@ly5156 ly5156 commented Jan 7, 2025

Summary

Fixes #13001

Occurred changes and/or fixed issues

The data method is expected to return a plain JavaScript object, which will be made reactive by Vue. Accessing or modifying unreturned data attributes in the data method may result in undesired issues

ref: https://vuejs.org/api/options-state.html#data

Technical notes summary

  1. When the component is initialized, the method call to select the first container is placed in the created lifecycle hooks.
  2. watch the active container changes and update fvFormRuleSets, in order to display the image form status in real time.

Areas or cases that should be tested

  1. should manual test that the form error prompts for the container are correct when creating or editing a workload
    ref: The general tab section missing error message on the Create or Edit workload page #13001

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@ly5156 ly5156 force-pushed the workload_data_method branch from 5aa0217 to 3ef4c72 Compare January 7, 2025 12:11
@gaktive gaktive requested a review from rak-phillip January 8, 2025 19:10
@rak-phillip rak-phillip added this to the v2.11.0 milestone Jan 9, 2025
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ly5156 Thanks for this change - it looks good and functions as described. I made sure to assign a proper milestone to this PR and the associated issue.

Can you make sure that the rest of the checklist is completed? We will not pass CI gates without this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The general tab section missing error message on the Create or Edit workload page
2 participants