Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-functional /signup endpoint #12955

Open
rancher-max opened this issue Dec 26, 2024 · 3 comments
Open

Remove non-functional /signup endpoint #12955

rancher-max opened this issue Dec 26, 2024 · 3 comments

Comments

@rancher-max
Copy link
Member

Is your feature request related to a problem? Please describe.

There exists a /signup endpoint by default in v2.10.1 (and earlier versions) that doesn't actually do anything. It appears that it is a public signup URL to manage the rancher instance or cluster, where people can submit a name and email, but no email actually arrives to register.

Describe the solution you'd like

We should remove this endpoint.

Describe alternatives you've considered

N/A

Additional context

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 26, 2024
@rancher-max rancher-max added area/navigation and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Dec 26, 2024
@richard-cox
Copy link
Member

richard-cox commented Dec 27, 2024

We should investigate where this came in and understand if it could still be in use, also the state of the rancher (assuming this wasn't something previously removed from the ui) endpoint it's calling

@rancher-max
Copy link
Member Author

I tried in fresh installs both in docker setup and HA with valid certs and in both of those cases, at least, it was essentially non-functional. Your point stands though that it may require some additional configurations and then becomes functional, so more investigation definitely needed.

@richard-cox
Copy link
Member

More on slack, but summarising...

  • Multiple new UI pages came in via User registration system ui#1023
    • signup
    • verify
    • verify-reset-password
  • Pages make requests to two endpoints
    • /register-new
    • /verify-token
  • Still not sure where this feature was used, but if those endpoints don't exist anywhere we should be safe to remove at least signup and probably the other two

@richard-cox richard-cox added the ember Ember UI Issue label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants