Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in WeakReferenceOnListChangedCallback #9

Open
m6s opened this issue Mar 4, 2016 · 0 comments
Open

Bug in WeakReferenceOnListChangedCallback #9

m6s opened this issue Mar 4, 2016 · 0 comments

Comments

@m6s
Copy link

m6s commented Mar 4, 2016

Came to your project via Stackoverflow, and found a bug. You're overriding onRangeMoved(), but you're delegating to notifyItemMoved(). This is only correct if itemCount is 1.

@Override
public void onItemRangeMoved(ObservableList sender, int fromPosition, int toPosition, int itemCount)
{
      RecyclerView.Adapter adapter = adapterReference.get();
      if (adapter != null)
      {
          adapter.notifyItemMoved(fromPosition, toPosition);
      }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant