Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Private Terraform Modules #6911

Closed
Tracked by #1
rynowak opened this issue Dec 4, 2023 · 4 comments · Fixed by #7167
Closed
Tracked by #1

Support for Private Terraform Modules #6911

rynowak opened this issue Dec 4, 2023 · 4 comments · Fixed by #7167
Assignees
@vishwahiremat
Labels
feature This issue describes a feature request in Radius triaged This issue has been reviewed and triaged

Comments

@rynowak
Copy link
Contributor

rynowak commented Dec 4, 2023 •
edited by azure-boards bot
Loading

Overview of feature request

Radius can work with publicly-hosted Terraform modules across a few different module sources. We don't support working with privately-hosted Terraform modules, and there's no way to configure authentication.

This is important because organizations write their own Terraform modules and store them in privately-accessible sources. In order for us to support serious use, we need to enable private sources.

The challenge is that each module source has its own authentication mechanism with its own style of configuration. For example the git module source relies on the environment hosting Terraform to provide the credentials.

For right now the set of required sources is TBD.

Acceptance criteria

Other than the "glue" to wire up credentials, the Terraform Recipe driver should behave the same way for a private module. Given the correct configuration of credentials, the Terraform driver should behave the same for a public vs private module.

  • Radius API allows users to register credentials for some set of Terraform module sources.
  • TBD set of Terraform module sources are supported.
  • Documentation updated.

Additional context

It may be helpful to pair this with the work to isolate the Terraform driver in its own container. Some of the source configuration makes changes to the execution environment (for example logging into git).

AB#10652
@rynowak rynowak added the feature This issue describes a feature request in Radius label Dec 4, 2023
@radius-triage-bot
Copy link

👋 @rynowak Thanks for filing this feature request.

A project maintainer will review this feature request and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@rynowak
Copy link
Contributor Author

rynowak commented Dec 4, 2023

Triage Team: creating this issue to track roadmap work.

This was referenced Dec 4, 2023
Closed
Closed
@shalabhms shalabhms added the triaged This issue has been reviewed and triaged label Dec 7, 2023
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@willtsai willtsai moved this to 🔖 Prioritized in Radius Roadmap Dec 15, 2023
@willtsai willtsai mentioned this issue Dec 15, 2023
Closed
@vishwahiremat vishwahiremat mentioned this issue Feb 13, 2024
Merged
kachawla pushed a commit that referenced this issue Feb 23, 2024
@vishwahiremat
Adding support for terraform private module source for git (#7167)
c0b50a5 
# Description

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
@AaronCrawfis
Copy link
Contributor

reopening as functional tests and docs still need to be created

@AaronCrawfis AaronCrawfis reopened this Feb 26, 2024
lakshmimsft pushed a commit to lakshmimsft/radius-mainfork that referenced this issue Feb 27, 2024
@vishwahiremat @lakshmimsft
Adding support for terraform private module source for git (radius-pr…
e3cbe2d 
…oject#7167)

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
lakshmimsft pushed a commit to lakshmimsft/radius-mainfork that referenced this issue Feb 27, 2024
@vishwahiremat @lakshmimsft
Adding support for terraform private module source for git (radius-pr…
8f281e6 
…oject#7167)

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
lakshmimsft pushed a commit to lakshmimsft/radius-mainfork that referenced this issue Feb 28, 2024
@vishwahiremat @lakshmimsft
Adding support for terraform private module source for git (radius-pr…
bc20220 
…oject#7167)

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
lakshmimsft pushed a commit to lakshmimsft/radius-mainfork that referenced this issue Feb 28, 2024
@vishwahiremat @lakshmimsft
Adding support for terraform private module source for git (radius-pr…
a4fb7b2 
…oject#7167)

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
lakshmimsft pushed a commit to lakshmimsft/radius-mainfork that referenced this issue Feb 28, 2024
@vishwahiremat @lakshmimsft
Adding support for terraform private module source for git (radius-pr…
0c5c1c9 
…oject#7167)

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Mar 4, 2024
@vishwahiremat @willdavsmith
Adding support for terraform private module source for git (radius-pr…
01b52d1 
…oject#7167)

# Description

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
@kachawla kachawla mentioned this issue Mar 11, 2024
Merged
vishwahiremat added a commit that referenced this issue Mar 11, 2024
@vishwahiremat
Adding env variables in functional test yaml to test private git modu…
56bd655 
…le source. (#7304)

# Description

Adding Environment Variables for Private Git source and Github token
(this pr need to go in before
#7260 to test the e2e test)

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes part of #6911

Signed-off-by: Vishwanath Hiremath <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Apr 8, 2024
@vishwahiremat @willdavsmith
Adding support for terraform private module source for git (radius-pr…
8d4e65a 
…oject#7167)

# Description

- Added a RecipeConfig property to the environment
  - Typesspec changes
  - Conversion and unit tests
  - Datamodel changes
- Adding changes to the config to append the template path with
credential informaiton
   - changes to query list secret to get secret information
   - creating credential appended template path

Design Doc: radius-project/design-notes#37

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6911

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishwahiremat vishwahiremat

Labels
feature This issue describes a feature request in Radius triaged This issue has been reviewed and triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding support for terraform private module source for git vishwahiremat/radius
5 participants
@rynowak @willtsai @shalabhms @AaronCrawfis @vishwahiremat