From 14fa6989b901d3d82aec8b5190a329b08949853c Mon Sep 17 00:00:00 2001 From: "Adam Ginsburg (keflavich)" Date: Fri, 18 Oct 2024 16:18:41 -0400 Subject: [PATCH] argmax/argmin need to return ints [some test code was removed] --- spectral_cube/tests/test_spectral_cube.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/spectral_cube/tests/test_spectral_cube.py b/spectral_cube/tests/test_spectral_cube.py index 4e73eccc..51c1c1e7 100644 --- a/spectral_cube/tests/test_spectral_cube.py +++ b/spectral_cube/tests/test_spectral_cube.py @@ -646,6 +646,14 @@ def test_argmax(self): self._check_numpy(self.c.argmax, d, np.nanargmax) self.c = self.d = None + def test_argmax_rays(self): + """ + regression test: argmax must have integer dtype + """ + d = np.where(self.d > 0.5, self.d, -10) + result = self.c.argmax(how='ray') + assert 'int' in str(result.dtype) + def test_argmin(self): d = np.where(self.d > 0.5, self.d, 10) self._check_numpy(self.c.argmin, d, np.nanargmin)