Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend "Testing Team" Page to Cover more Roles #102

Open
ros-cr opened this issue Nov 18, 2022 · 1 comment
Open

Extend "Testing Team" Page to Cover more Roles #102

ros-cr opened this issue Nov 18, 2022 · 1 comment

Comments

@ros-cr
Copy link
Contributor

ros-cr commented Nov 18, 2022

At the moment, the testing team section includes a table of name + biography snippet entries for all pentesters and the approver via <generate_testteam/>.

I would like to start a discussion around potential ways to extend this section to cover more people who were personally involved in the pentest and report. It is also a good opportunity to clarify the individual roles of the people listed in the table, so that the reader doesn't have to jump to the other end of the report and look up roles manually in the "Document Properties" table on page two.

Primarily, I think it would be fairly straightforward to add the reviewer to this table of involved contributors.

My initial design is to keep using one table for the whole team and adding role descriptions ("Pentester", "Reviewer", "Approver") in a second line under their name in the left column. I've experimented with italic font style for the role label, but other styles may work as well.

I anticipate the need to change the format for the <reviewers> list in report.xml since each <reviewer> would need a name and biography field instead of purely a name.

The most problematic edge case I can think of is if one person fulfills roles in more than one category to avoid multiple entries in the table for one person.

@Synchro
Copy link
Contributor

Synchro commented Nov 18, 2022

Perhaps flip it around and have a people section, each of which can have roles attached?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants