Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny issues (not critical for tmap4 release) #1024

Open
mtennekes opened this issue Jan 10, 2025 · 0 comments
Open

shiny issues (not critical for tmap4 release) #1024

mtennekes opened this issue Jan 10, 2025 · 0 comments

Comments

@mtennekes
Copy link
Member

mtennekes commented Jan 10, 2025

There are still a couple of shiny issues:

  1. renderTmap had mode-specific functions (not S3 but sort of): https://github.com/r-tmap/tmap/blob/master/R/tmapLeafletShiny.R However, I tried calling these functions with do.call https://github.com/r-tmap/tmap/blob/master/R/shiny.R#L46-L47 but that didn't work. For now, I hard-coded the mode-specific approached in these functions, with an error for modes other than plot and view.

  2. Probably my lack of shiny knowledge. In view mode, tmapProxy is already triggered at start up. So after the initial map rendering, the map is immediately updated, which takes a bit of time. See code in this vignette https://r-tmap.github.io/tmap/articles/adv_shiny#view-mode

  3. In the same code example, the tmapProxy doesn't work when the original (projected) sf objects are used.

The examples in the documentation and the vignette work, so these issues are not critical for the upcoming tmap4 release.

mtennekes added a commit that referenced this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant