Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline use #2

Open
cneud opened this issue Aug 15, 2019 · 4 comments
Open

Offline use #2

cneud opened this issue Aug 15, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@cneud
Copy link
Member

cneud commented Aug 15, 2019

The stylesheet for the report linked as <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css"...> should be distributed with the sources in order to support the rendering even when the tool is used offline.

@mikegerber mikegerber added the enhancement New feature or request label Aug 16, 2019
@mikegerber
Copy link
Member

I'm going to install these dependencies statically in the future, i.e. download once upon install.

@kba
Copy link
Contributor

kba commented Aug 16, 2019

I tend to resort to package.json + webpack once dependencies become non-trivial.

@mikegerber mikegerber self-assigned this Nov 18, 2019
@mikegerber
Copy link
Member

mikegerber commented Nov 18, 2019

Some loud thinking:

a. Leave as is → Reports work everywhere, but not offline
b. Install CSS+JS to /usr/local (or equivalent) → Reports work on the local machine, even offline, but not everywhere else

Probably going down the b road, but have an option to have the reports to be "portable". (Is there a way to have a fallback URL for CSS/JS? That would do it.)

@cneud
Copy link
Member Author

cneud commented Nov 18, 2019

You could always minify the CSS+JS and include it inline for maximum portability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants