Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button should support href and target props #23

Open
thabti opened this issue Mar 9, 2017 · 6 comments
Open

Button should support href and target props #23

thabti opened this issue Mar 9, 2017 · 6 comments

Comments

@thabti
Copy link
Contributor

thabti commented Mar 9, 2017 •
edited
Loading

Bootstrap button has a prop for href which would style an <a> like a button and apply the href value.
@thabti thabti changed the title Button should support href props Button should support href and target props Mar 9, 2017
@thabti thabti closed this as completed in 88d4372 Mar 9, 2017
@mmahalwy
Copy link
Contributor

hmm got to careful with this and react-router

@thabti
Copy link
Contributor Author

thabti commented Mar 10, 2017

Yeah - anything I should be mindful of? There is always the onClick escape hatch. And we might eventually provide a way to support styling .

@thabti thabti reopened this Mar 10, 2017
@thabti
Copy link
Contributor Author

thabti commented Mar 10, 2017

The name will still be "Button" and not Link. I will update the storybook to Button as to not be confusing.

@mmahalwy
Copy link
Contributor

LinkContainer would work. See: https://github.com/react-bootstrap/react-router-bootstrap/blob/master/src/LinkContainer.js

@thabti
Copy link
Contributor Author

thabti commented Mar 10, 2017

Yep it would I used it on the audio repo

@mmahalwy
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thabti @mmahalwy