Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A strange phenomenon about quiver sampler #122

Open
DesmonDay opened this issue Feb 28, 2022 · 6 comments
Open

A strange phenomenon about quiver sampler #122

DesmonDay opened this issue Feb 28, 2022 · 6 comments
Assignees

Comments

@DesmonDay
Copy link

Hi, thank you for your wonderful opensouce works about Quiver. Recently I was trying to look deep into the sampler module, but met a quite strange phenomenon. We can see the following picture. I was testing about the quiver sampler speed and model training speed.

Machine 1: Tesla V100-SXM2-16GB, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, 20 physical CPU cores.
Model: GraphSage, batch_size=128, samples=[25,10], Reddit.

屏幕快照 2022-02-28 上午10 45 07
It seems very strange, because the time cost by sampler and model training is less than only using sampler.

I try several methods to figure out the reason, like DataLoader, CUDA Stream, etc, but still confused. Maybe you can help me?

@eedalong
Copy link
Member

eedalong commented Mar 1, 2022

Well, this is strange

@eedalong
Copy link
Member

eedalong commented Mar 1, 2022

What is your quiver_sampler's mode

@eedalong eedalong self-assigned this Mar 1, 2022
@DesmonDay
Copy link
Author

UVA. But I remember that GPU mode has the same phenomenon, if my memory is correct.

@eedalong
Copy link
Member

eedalong commented Mar 1, 2022

That's odd, let me check it

@DesmonDay
Copy link
Author

hi, have you figured out the reason?

@LukeLIN-web
Copy link

hi, have you figured out the reason?

Hi, I would like to ask how do you run the quiver. I install torch-quiver 0.1.0 from https://github.com/quiver-team/torch-quiver/blob/main/docker/README.md
when i run examples/pyg/reddit_quiver.py,
it shows AttributeError: module 'torch_quiver' has no attribute 'device_quiver_from_csr_array'. I tried their docker image and it shows AttributeError: Can't get attribute 'DataEdgeAttr' on <module 'torch_geometric.data.data' from '/opt/conda/lib/python3.7/site-packages/torch_geometric/data/data.py'>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants