Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding elasticsearch to the main.tf optional examples #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

QuiltSimon
Copy link

Description

Clarifying documentation to make ElasticSearch sizing call outs more obvious. Resolves #80 .

TODO

@QuiltSimon QuiltSimon requested a review from sir-sigurd January 7, 2025 15:11
Comment on lines +11 to +14
## [Unreleased]

- Chanded documentation to include elasticsearch instance sizing in the `Quilt` tf module. ([#79](https://github.com/quiltdata/iac/pull/79))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it doesn't make sense to add changelog entry for docs only change

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that makes sense to me, I just wanted to conform to the process. I'll drop it and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how to apply ElasticSearch Size
2 participants