-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aii pxelinux write failure #258
Comments
@jouvin this is during a reinstall, no uefi settings applied yet |
fixed with comments in PR https://github.com/quattor/aii/pull/225/files#r103927865 and https://github.com/quattor/aii/pull/225/files#r103927717 |
I apologize about this. I did this yesterday evening and I was sure that I installed the new version since then... Clearly not. And I was sure that a typo would be catched by unit tests when these methods are not. PR #255 fixed now. Unit test still to be added: I keep this issue open until it is done. |
- Includes some code refactoring/cleanup - Unit tests adjusted to test PXELINUX and Grub2 variants, including - pxelinux_no_append_block.t removed (superseded by write_pxelinux_config.t) - Several pxelinux_ks_xxx tests merged for easier maintenance (coverage and regexps tests are identical) - Fixes quattor#258 (caused by a typo in the initial version of this commit)
- Includes some code refactoring/cleanup - Unit tests adjusted to test PXELINUX and Grub2 variants, including - pxelinux_no_append_block.t removed (superseded by write_pxelinux_config.t) - Several pxelinux_ks_xxx tests merged for easier maintenance (coverage and regexps tests are identical) - Fixes quattor#258 (caused by a typo in the initial version of this commit)
- Includes some code refactoring/cleanup - Unit tests adjusted to test PXELINUX and Grub2 variants, including - pxelinux_no_append_block.t removed (superseded by write_pxelinux_config.t) - Several pxelinux_ks_xxx tests merged for easier maintenance (coverage and regexps tests are identical) - Fixes quattor#258 (caused by a typo in the initial version of this commit)
- Includes some code refactoring/cleanup - Unit tests adjusted to test PXELINUX and Grub2 variants, including - pxelinux_no_append_block.t removed (superseded by write_pxelinux_config.t) - Several pxelinux_ks_xxx tests merged for easier maintenance (coverage and regexps tests are identical) - Fixes quattor#258 (caused by a typo in the initial version of this commit)
- Includes some code refactoring/cleanup - Unit tests adjusted to test PXELINUX and Grub2 variants, including - pxelinux_no_append_block.t removed (superseded by write_pxelinux_config.t) - Several pxelinux_ks_xxx tests merged for easier maintenance (coverage and regexps tests are identical) - Fixes quattor#258 (caused by a typo in the initial version of this commit)
#225 is supposed to close this issue... but I have no problem if you close it before... |
- Includes some code refactoring/cleanup - Unit tests adjusted to test PXELINUX and Grub2 variants, including - pxelinux_no_append_block.t removed (superseded by write_pxelinux_config.t) - Several pxelinux_ks_xxx tests merged for easier maintenance (coverage and regexps tests are identical) - Fixes quattor#258 (caused by a typo in the initial version of this commit)
related to #225
ugly failure due to missing function/method?
The text was updated successfully, but these errors were encountered: