-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
&name=large.png
added to markdown image urls
#11247
Comments
You sure? Two identical files, one is ![](https://pbs.twimg.com/media/Ga-G5MtWIAAjpC6?format=jpg&name=large)
correctly renders <p><img
src="https://pbs.twimg.com/media/Ga-G5MtWIAAjpC6?format=jpg&name=large" /></p> but
generates a bunch of stuff including this line <p><img src="https://pbs.twimg.com/media/Ga-G5MtWIAAjpC6?format=jpg&name=large.png" class="img-fluid"></p> |
The "src" attribute is exactly the same in both of the outputs you shared which is basically what Carlos already established. edit: is the |
Quoting from your answer:
See the |
The I can also do this (Markdown) workaround to force the correct src, which renders properly in both Quarto and Pandoc: <img src="https://pbs.twimg.com/media/Ga-G5MtWIAAjpC6?format=jpg&name=large" alt=""> why does Quarto append that extra (Might be unrelated, but back in #7102 I thought it was reasonable that Quarto decided to not guess the image type, so I wonder if this is a change?) |
This is added because of If you do |
Thanks for the added context. @tarleb what do you think about a change to the default-image-extension behavior where Pandoc would try to append the extension before the URL params, if it finds them? |
This seems related to jgm/pandoc#9118. It could be argued that the fix for that issue was incomplete, and that URLs should never be altered. Are there situations in which the Having that feature limited to local images would seem reasonable to me. |
I think most common use case if local image, but you could imagine users (of Quarto or Pandoc) that would have there image online with a .png and .pdf version available and they would like html format to use .png and pdf format to use pdf format. Doing this with [Caption](https://mysite.co/my-img) Not that common but could happen. So it would be a breaking change for such users. A choice to make. For the story we do set ---
format:
pdf: default
html: default
---
[Caption](images/my-awesome-img)
Doing this would insure nothing is broken IMO. And this would indeed complete jgm/pandoc#9118. |
I've opened jgm/pandoc#10355 to keep track of this. |
Bug description
how come this markdown image
![](https://pbs.twimg.com/media/Ga-G5MtWIAAjpC6?format=jpg&name=large)
gets turned into this html:
<p><img src="https://pbs.twimg.com/media/Ga-G5MtWIAAjpC6?format=jpg&name=large.png" class="img-fluid" data-format="image/jpeg"></p>
Note the
&name=large.png
appended to the end of the src url.Steps to reproduce
make a qmd file with this line
![](https://pbs.twimg.com/media/Ga-G5MtWIAAjpC6?format=jpg&name=large)
quarto render
Expected behavior
No response
Actual behavior
No response
Your environment
No response
Quarto check output
Quarto 1.5.45
[✓] Checking versions of quarto binary dependencies...
Pandoc version 3.2.0: OK
Dart Sass version 1.70.0: OK
Deno version 1.41.0: OK
Typst version 0.11.0: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
Version: 1.5.45
Path: /Applications/quarto/bin
The text was updated successfully, but these errors were encountered: