Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Database][Devservice] Support multiple init scripts #45474

Open
agreedSkiing opened this issue Jan 9, 2025 · 5 comments
Open

[Database][Devservice] Support multiple init scripts #45474

agreedSkiing opened this issue Jan 9, 2025 · 5 comments
Labels
area/jdbc Issues related to the JDBC extensions good first issue Good for newcomers kind/enhancement New feature or request

Comments

@agreedSkiing
Copy link
Contributor

Description

Since the database devservice support an init script would it be possible to add a new parameter to load mulitple init scripts?

Use case are for application that don't use flyway

Implementation ideas

No response

@agreedSkiing agreedSkiing added the kind/enhancement New feature or request label Jan 9, 2025
Copy link

quarkus-bot bot commented Jan 9, 2025

/cc @geoand (devservices), @stuartwdouglas (devservices)

@geoand geoand added area/jdbc Issues related to the JDBC extensions and removed area/devservices labels Jan 9, 2025
@geoand
Copy link
Contributor

geoand commented Jan 9, 2025

cc @yrodiere

@yrodiere
Copy link
Member

yrodiere commented Jan 9, 2025

Not only is it possible, it should be fairly easy and thus is a good candidate for first-time contributors! Want to give it a try? :)

Entry points:

  1. Here's where the config for init scripts is defined -- it'll need to be turned into a List<@WithConverter(TrimmedStringConverter.class) String> and usages will have to be adapted to handle multiple values:
  2. Here's where it gets stored temporarily before being forwarded to containers -- same deal, will need to be turned to a List<String>:
  3. Here's where it gets passed to testcontainers for postgresql -- need to use withInitScripts (trailing s) instead of withInitScript:
    Same thing needs to be done for other databases, of course.

@yrodiere yrodiere added the good first issue Good for newcomers label Jan 9, 2025
@giamma-frangipane
Copy link

I'd like to contribute!

@yrodiere
Copy link
Member

yrodiere commented Jan 9, 2025

Please do!

General help: https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md

Specifics of this issue: see my previous comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jdbc Issues related to the JDBC extensions good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants