-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quarkus.otel.traces.suppress-non-application-uris
not working with quarkus.management.enabled
#36510
Comments
/cc @brunobat (opentelemetry,tracing), @radcortez (opentelemetry,tracing) |
We face the same issue. We have set these settings:
The requests to /management/health and /management/metrics are being recorded now, which produces a lot of unnecessary traces. |
I would like to work on this |
Ok @b3lix, go for it. |
Whats the current status of this? Otherwise I would like to give this a go. |
@b3lix, Do you mind if @nielsvhaldvb works on this? |
@brunobat @nielsvhaldvb hello, I dropped this effort, so yes go ahead please, and good luck. |
@nielsvhaldvb Do you still plan to work on this? |
I have a similar issue, with Quarkus 3.15.1 LTS and
|
Management URLs were prefixed twice when absolute: http://localhost:9000http://localhost:9000/q/health Which was defeating the logic removing the host when collecting suppressed URIs. Fixes quarkusio#36510
I created #45300 that should hopefully address this problem. |
Describe the bug
The default behaviour of
quarkus.otel.traces.suppress-non-application-uris
is to suppress trace collection of non applicative uris, everything is fine with standard confs, but if I enable the management interface throughquarkus.management.enabled=true
suppresion will fail.Expected behavior
With
quarkus.management.enabled
set to true, health check will be redirect to0.0.0.0:9000/q/health
and trace collection will continue to be suppresed.Actual behavior
Otel trace collection is not suppressed and it seems that
quarkus.otel.traces.suppress-non-application-uris
is been ignored.How to Reproduce?
application.yaml
curl localhost:9000/q/health
Output of
uname -a
orver
Darwin *** 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000 arm64
Output of
java -version
openjdk 17.0.6 2023-01-17 OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10) OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode)
GraalVM version (if different from Java)
No response
Quarkus version or git rev
3.4.3
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.9.3
Additional information
No response
The text was updated successfully, but these errors were encountered: