From 1641ca95ea3d2d8a3e0df7996111e2271972a9f2 Mon Sep 17 00:00:00 2001 From: Jappie Klooster Date: Wed, 8 Dec 2021 11:34:57 +0100 Subject: [PATCH 1/4] Change comment from tab support to write multiple sheets --- src/Codec/Xlsx/Writer/Stream.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Codec/Xlsx/Writer/Stream.hs b/src/Codec/Xlsx/Writer/Stream.hs index deefa0da..430a2f66 100644 --- a/src/Codec/Xlsx/Writer/Stream.hs +++ b/src/Codec/Xlsx/Writer/Stream.hs @@ -133,7 +133,7 @@ defaultSettings = MkSheetWriteSettings -- the others are exposed in case you can cache the shared strings for example. -- -- Note that the current implementation concatenates everything into a single sheet. --- In other words there is no tab support yet. +-- In other words there is no support for writing multiple sheets writeXlsx :: MonadThrow m => PrimMonad m => SheetWriteSettings -- ^ use 'defaultSettings' From 62b0490bc5e2e852a7a21f9ecc3a952b9fee7635 Mon Sep 17 00:00:00 2001 From: Jappie Klooster Date: Wed, 8 Dec 2021 11:40:01 +0100 Subject: [PATCH 2/4] Delete commented out code --- src/Codec/Xlsx/Writer/Stream.hs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Codec/Xlsx/Writer/Stream.hs b/src/Codec/Xlsx/Writer/Stream.hs index 430a2f66..207d902c 100644 --- a/src/Codec/Xlsx/Writer/Stream.hs +++ b/src/Codec/Xlsx/Writer/Stream.hs @@ -274,7 +274,6 @@ sheetViews = do let view' :: [Element] view' = setNameSpaceRec spreadSheetNS . toXMLElement . toElement (n_ "sheetView") <$> sheetView - -- tag (n_ "sheetView") (attr "topLeftCell" "D10" <> attr "tabSelected" "1") $ pure () C.yieldMany $ elementToEvents =<< view' From bc2294be842c9a9b03c164874d8100eb5e418bdd Mon Sep 17 00:00:00 2001 From: Jappie Klooster Date: Wed, 8 Dec 2021 12:21:02 +0100 Subject: [PATCH 3/4] Remove unused pragmas --- test/Main.hs | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/Main.hs b/test/Main.hs index d9fb9b63..c57b5360 100644 --- a/test/Main.hs +++ b/test/Main.hs @@ -1,8 +1,5 @@ --- {-# OPTIONS_GHC -F -pgmF tasty-discover #-} {-# LANGUAGE OverloadedLists #-} {-# LANGUAGE OverloadedStrings #-} -{-# LANGUAGE QuasiQuotes #-} -{-# LANGUAGE RecordWildCards #-} module Main ( main ) where From 4e84995e44ccfc6961ab19e9493122444d5090c7 Mon Sep 17 00:00:00 2001 From: Jappie Klooster Date: Wed, 8 Dec 2021 12:27:09 +0100 Subject: [PATCH 4/4] Remove unused dependencies --- xlsx.cabal | 5 ----- 1 file changed, 5 deletions(-) diff --git a/xlsx.cabal b/xlsx.cabal index 88a732a7..4e6b58e7 100644 --- a/xlsx.cabal +++ b/xlsx.cabal @@ -36,7 +36,6 @@ Flag microlens Library Hs-source-dirs: src - profiling: False ghc-options: -Wall Exposed-modules: Codec.Xlsx , Codec.Xlsx.Types @@ -87,7 +86,6 @@ Library Other-modules: Codec.Xlsx.Parser.Stream.HexpatInternal Build-depends: base >= 4.9.0.0 && < 5.0 - , async , attoparsec , base64-bytestring , binary-search @@ -101,7 +99,6 @@ Library , extra , filepath , hexpat - , List , mtl >= 2.1 , network-uri , old-locale >= 1.0.0.5 @@ -118,8 +115,6 @@ Library , zip-stream >= 0.2.0.1 , xml-types , exceptions - , lifted-async - , stm , transformers-base , monad-control if flag(microlens)