SizeAndTimeBasedFNATP was renamed but is still mentionned in the documentation

[guilgaly]

In the latest release (1.5.8), SizeAndTimeBasedFNATP was renamed to SizeAndTimeBasedFileNamingAndTriggeringPolicy (in this commit).

However:

• The documentation, in the Appenders chapter, mentions that SizeAndTimeBasedFNATP should still work although it's no longer recommended.

  In versions prior to 1.1.7, this document mentioned a component called SizeAndTimeBasedFNATP. However, given that SizeAndTimeBasedRollingPolicy offers a simpler configuration structure, we no longer document SizeAndTimeBasedFNATP. Nevertheless, earlier configuration files using SizeAndTimeBasedFNATP will continue to work just fine. In fact, SizeAndTimeBasedRollingPolicy is implemented with a SizeAndTimeBasedFNATP subcomponent.

• The constant CoreConstants.SIZE_AND_TIME_BASED_FNATP_IS_DEPRECATED, still mentions the name SizeAndTimeBasedFNATP in a deprecation warning in case of direct usage of SizeAndTimeBasedFileNamingAndTriggeringPolicy.

By the way, the name SizeAndTimeBasedFNATP still also appears in various places in the code, but those aren't user-visible.

I guess that either SizeAndTimeBasedFNATP shouldn't have been renamed (if its direct use is still supposed to work, although deprecated), or the documentation should be updated.

[fenik17]

@ceki
Also, this renaming broke our configurations.
It would be nice to add a subclass with the old name for backward compatibility.

[ceki]

SizeAndTimeBasedFNATP now extends SizeAndTimeBasedFileNamingAndTriggeringPolicy preserving backward compatibility with existing configuration files. See commit 80db86b

[ceki]

@fenik17 Would you care to check whether the commit 80db86b fixes the issue?

[fenik17]

@ceki I checked - your fix helped, everything works. Thank you for such a quick response! Although, of course, we have already updated our configurations to use SizeAndTimeBasedRollingPolicy.