Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or change metrics meaning for 2 groups of metrics: client.*, cluster_grinder.* #817

Open
ikopylov opened this issue Jun 9, 2023 · 0 comments
Labels
feature New feature or request

Comments

@ikopylov
Copy link
Member

ikopylov commented Jun 9, 2023

cluster_grinder is better to rename to cluster.
The main problem is with the client.* metrics. It is not clear what these metrics are for. I think, it is better to change the name and meaning of these metrics. To track performance, we are interested in getting metrics for the entire range of requests for a node (regardless of the force_node flag). So it would be good to track the values for the whole incoming put/get/exist/delete operations, not just for the case when force_node == true. And the metrics in this case can be names as node. Basically, that means that node = client + cluster_grinder

@ikopylov ikopylov added the feature New feature or request label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant