-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format change for XDENS #160
Comments
I have renamed the issue subject since a more general solution to my problem is to change the format of XDENS. My problem is that we have gigantic files but most numbers in there are insignificant for tests and benchmarks. My suggestion:
The advantage of this format is that one could leave out insignificant values and only provide the significant numbers. With this we could put benchmarks into the repo. Suggestions/opinions? |
The code would check if first line contains a version. If not, default to old code. If yes, engage new read-in which allows leaving out all the zeros. |
The other bonus would be that you actually see which matrix row and column a number corresponds to. Now you just see a series of numbers and have no idea to what they belong to unless you look into the code. |
We have to keep in mind that the structure for open-shell cases in XDENS might vary. Did you consider this? What sort of format do you have in mind? If we can switch it on/off and use it only for benchmarking purpose eg. sharing the benchmark it might be indeed useful. Going completely for the new format option is something that needs a bit more time from my point of view. All scripts/interfaces to other QM codes use the current format. |
Your idea sounds reasonable, I do not understand yet what new format you have in mind and how and if it would affect applications. |
Well in this issue I want to replace very large XDENS files by small files with essentially the same result. Please note that most numbers in XDENS files contribute nothing to the final result. The proposal that I suggest would not break existing formats. The code would check whether this is old or new format and be able to read both. |
I like your idea. If this works properly we would not need to merge the pull request #162. Again: did you consider open-shell as well? Or would this just be an convenient closed-shell option? I know in principle it should not matter but as far as I remember the ordering on XDENS changes for open-shell cases so I have to ask this question to be on the save side. |
In the new format the order of elements will not matter. |
What about open-shell? |
The order of basis functions matters. |
Not for my suggested format :-) |
As indicated above it is not clear to me what your new format exactly is. Time for a call next week. :) |
OK now XDENS is just a sequence of numbers
Problems:
What I suggest is:
In this case we give 3 elements (1, 2), (3, 4), and (137, 137). Advantages:
|
We have currently an XDENS file. Do you want to read and modify it in the alternative format? If yes you need to change probably as well the code inside gimic to deal with the new xdens file. What about the slicing procedure for the integration? The precision there probably will depend on the defined threshhold for the numbers to throw away. |
Yes, this would require modifying the code reading it. The computations will of course depend on the cutoff but one does not have to use a cutoff. My suggestion only enables to use a cutoff. |
That is fine. We can go for it. |
I would like to make it possible to read in density matrices in a "compressed" format where we skip zeros and very small numbers, in other words some sparse format. This would make it possible to put benchmarks into this repository and not explode disk space.
The text was updated successfully, but these errors were encountered: