testqgs3drendering: Add a unit test for phong textured material

[ptitjano]

Description

The qt6 version works. The qt5 version works on my machine. It fails on the CI with a wrong color. I don't know what happens here.

cc @nyalldawson

qt5 expected image

qt5 ci result

[github-actions]

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 8f378bf)

[github-actions]

Tests failed for Qt 5

One or more tests failed using the build from commit 426997a

polygon3d_extrusion_textured_phong (testExtrudedPolygonsTexturedPhong)

polygon3d_extrusion_textured_phong

Test failed at testExtrudedPolygonsTexturedPhong at tests/src/3d/testqgs3drendering.cpp:535

• Rendered image did not match tests/testdata/control_images/3d/expected_polygon3d_extrusion_textured_phong/default/expected_polygon3d_extrusion_textured_phong.png (found 40158 pixels different)
• Rendered image did not match tests/testdata/control_images/3d/expected_polygon3d_extrusion_textured_phong/qt6/expected_polygon3d_extrusion_textured_phong.png (found 40969 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

[github-actions]

Tests failed for Qt 6

One or more tests failed using the build from commit 5e71c6e

polygon3d_extrusion_textured_phong (testExtrudedPolygonsTexturedPhong)

polygon3d_extrusion_textured_phong

Test failed at testExtrudedPolygonsTexturedPhong at tests/src/3d/testqgs3drendering.cpp:532

Rendered image did not match tests/testdata/control_images/3d/expected_polygon3d_extrusion_textured_phong/expected_polygon3d_extrusion_textured_phong.png (found 4816 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

[nyalldawson]

I can't explain that! Maybe just skip it on ci for qt5 builds.... A test which works on qt6 alone (and locally) is still better than no test at all 🙃

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

[ptitjano]

I can't explain that! Maybe just skip it on ci for qt5 builds.... A test which works on qt6 alone (and locally) is still better than no test at all 🙃

Done. The test is now skipped on CI for Qt5.

[github-actions]

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.