Implement converter for esriTS symbols for featureServers #58076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement parseEsriTextMarkerSymbolJson Add test for chr parameter Set chr parameter to text Implement borderLineSize width Add test for borderLineSize Add test for strokeColor Implement strokeColor Implement anchor points Add tests for anchor points Add test for angle Add test for offset Set sizeUnit Set offset Remove fontData map Add more specific tests Create parseEsriTextMarkerSymbolJson function Add tests Add necessary additional information to test json
nyalldawson
reviewed
Jul 12, 2024
|
Nice work @merydian -- this is nearly ready! |
…ppropriate Co-authored-by: Nyall Dawson <[email protected]>
Co-authored-by: Nyall Dawson <[email protected]>
Co-authored-by: Nyall Dawson <[email protected]>
nyalldawson
added
the
Squash!
nyalldawson
approved these changes
Jul 17, 2024
nyalldawson
reviewed
Jul 17, 2024
|
Nice work @merydian ! Welcome to core QGIS development! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The file qgsarcgisrestutils.cpp curently does not support conversions for esriTS type symbols. This pull request adds functionality to convert esriTS symbols in ArcGis featureServers to a QgsMarkerSymbol. When loading featureServers with this symbol type, symbols will now load automatically.