Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processing][feature] Enhance the GDAL "Vector information" alg and add a new GDAL "Vector information (JSON)" alg #57976

Merged

Conversation

agiudiceandrea
Copy link
Contributor

@agiudiceandrea agiudiceandrea commented Jul 3, 2024

Description

  • Enhancements of the "Vector information" (gdal:ogrinfo) GDAL processing algorithm:
    The checkbox parameter ALL_LAYERS "Enable listing of all layer information", False by default, is added in order for the layer name to not be added to the ogrinfo command-line so it will output the info of all the layers in the dataset (see also Add parameter to skip layername in gdal:convertformat #45955).
    The advanced parameter EXTRA "Additional command-line parameters" (optional) is added in order to provide additional command-line options to the ogrinfo command (to be consistent with the "Raster information" (gdal:gdalinfo) GDAL processing algorithm (see also [processing] allow passing additional command line parameters to GDAL algorithms #30377).

    image

  • New "Vector information (JSON)" (gdal:ogrinfojson) GDAL processing algorithm (only available with GDAL >= 3.7):
    This algorithm will use the -json option of ogrinfo in order to create a JSON file containing the layer or dataset information.
    It has the same parameters as "Vector information" (gdal:ogrinfo), except for the parameter SUMMARY_ONLY "Summary output only" (-so option), which is replaced by FEATURES "Enable listing of features" (-features option), False by default.
    The algorithm output is a JSON file.
    I think this new algorithm fixes add -json option in ogrinfo outputs #57945.

    image

@github-actions github-actions bot added this to the 3.40.0 milestone Jul 3, 2024
@agiudiceandrea agiudiceandrea added Feature Processing Relating to QGIS Processing framework or individual Processing algorithms labels Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit ef196de)

@agiudiceandrea agiudiceandrea added the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Jul 3, 2024
@agiudiceandrea agiudiceandrea force-pushed the fix-feature-57945-ogrinfo-ogrinfojson branch from 0eda6f2 to ef196de Compare July 4, 2024 10:09
@agiudiceandrea agiudiceandrea removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Jul 4, 2024
@nyalldawson nyalldawson merged commit 5f85a82 into qgis:master Jul 10, 2024
29 checks passed
@nyalldawson nyalldawson added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jul 10, 2024
@qgis-bot
Copy link
Collaborator

@agiudiceandrea

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@agiudiceandrea agiudiceandrea deleted the fix-feature-57945-ogrinfo-ogrinfojson branch July 16, 2024 19:40
@agiudiceandrea agiudiceandrea added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Jul 16, 2024
@qgis-bot
Copy link
Collaborator

@agiudiceandrea
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@agiudiceandrea
A documentation ticket has been opened at qgis/QGIS-Documentation#9170
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add -json option in ogrinfo outputs
4 participants