From 34d85e4afc8ec7ac4e5d50fb481eb923b72f3929 Mon Sep 17 00:00:00 2001
From: Withalion <matej.bagar@lutraconsulting.co.uk>
Date: Sat, 1 Mar 2025 15:42:34 +0100
Subject: [PATCH] Add new icons for line tool

---
 images/images.qrc                             |  2 +
 .../themes/default/mActionSelectAboveLine.svg | 59 ++++++++++++++++++
 .../themes/default/mActionSelectBelowLine.svg | 60 +++++++++++++++++++
 src/app/3d/qgs3dmapcanvaswidget.cpp           |  4 +-
 4 files changed, 123 insertions(+), 2 deletions(-)
 create mode 100644 images/themes/default/mActionSelectAboveLine.svg
 create mode 100644 images/themes/default/mActionSelectBelowLine.svg

diff --git a/images/images.qrc b/images/images.qrc
index 24bb0f5eb87a..7a3a27776e38 100644
--- a/images/images.qrc
+++ b/images/images.qrc
@@ -413,6 +413,8 @@
         <file>themes/default/mActionScaleFeature.svg</file>
         <file>themes/default/mActionScriptOpen.svg</file>
         <file>themes/default/mActionSelect.svg</file>
+        <file>themes/default/mActionSelectAboveLine.svg</file>
+        <file>themes/default/mActionSelectBelowLine.svg</file>
         <file>themes/default/mActionSelectAll.svg</file>
         <file>themes/default/mActionSelectedToTop.svg</file>
         <file>themes/default/mActionSelectFreehand.svg</file>
diff --git a/images/themes/default/mActionSelectAboveLine.svg b/images/themes/default/mActionSelectAboveLine.svg
new file mode 100644
index 000000000000..02dd0591ad6d
--- /dev/null
+++ b/images/themes/default/mActionSelectAboveLine.svg
@@ -0,0 +1,59 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg
+   height="24"
+   width="24"
+   version="1.1"
+   id="svg5"
+   sodipodi:docname="mActionSelectPolygon.svg"
+   inkscape:version="1.4 (e7c3feb100, 2024-10-09)"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:svg="http://www.w3.org/2000/svg">
+  <defs
+     id="defs5" />
+  <sodipodi:namedview
+     id="namedview5"
+     pagecolor="#ffffff"
+     bordercolor="#000000"
+     borderopacity="0.25"
+     inkscape:showpageshadow="2"
+     inkscape:pageopacity="0.0"
+     inkscape:pagecheckerboard="0"
+     inkscape:deskcolor="#d1d1d1"
+     inkscape:zoom="39.958333"
+     inkscape:cx="12"
+     inkscape:cy="12"
+     inkscape:window-width="2133"
+     inkscape:window-height="1168"
+     inkscape:window-x="0"
+     inkscape:window-y="0"
+     inkscape:window-maximized="1"
+     inkscape:current-layer="g5" />
+  <g
+     transform="translate(0,-1028.3622)"
+     id="g5"
+     style="display:inline">
+    <path
+       style="fill:#e5e5e5;fill-opacity:1;stroke:none;stroke-width:1.21;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1"
+       d="m 0.60062565,1038.8481 19.16996835,-8.5589 v -1.902 H 0.57559958 Z"
+       id="path9" />
+    <path
+       d="M 2.5384617,1030.9006 H 15.46154 v 12.9231 H 2.5384617 Z"
+       fill="#fce94f"
+       stroke="#c4a000"
+       stroke-linecap="round"
+       stroke-width="1.07692"
+       id="path3"
+       style="display:inline" />
+    <path
+       d="m 22.652743,1044.0577 -12.756464,-6.9791 5.477553,13.6014 2.180887,-3.5312 4.312159,4.7134 1.633122,-1.5913 -4.408599,-4.6683 3.561343,-1.5449 z"
+       style="display:inline;fill:#ffffff;fill-rule:evenodd;stroke:#000000;stroke-width:0.7;stroke-linecap:round;stroke-linejoin:round"
+       id="path5" />
+    <path
+       style="fill:#424242;fill-opacity:1;stroke:#424242;stroke-width:1.21;stroke-opacity:1;stroke-dasharray:4.84000015, 1.21000004;stroke-dashoffset:0"
+       d="M 0.86932117,11.063943 20.052472,2.4501349"
+       id="path6"
+       transform="translate(0,1028.3622)" />
+  </g>
+</svg>
diff --git a/images/themes/default/mActionSelectBelowLine.svg b/images/themes/default/mActionSelectBelowLine.svg
new file mode 100644
index 000000000000..7e0c765e88a8
--- /dev/null
+++ b/images/themes/default/mActionSelectBelowLine.svg
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg
+   height="24"
+   width="24"
+   version="1.1"
+   id="svg5"
+   sodipodi:docname="mActionSelectPolygon.svg"
+   inkscape:version="1.4 (e7c3feb100, 2024-10-09)"
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
+   xmlns="http://www.w3.org/2000/svg"
+   xmlns:svg="http://www.w3.org/2000/svg">
+  <defs
+     id="defs5" />
+  <sodipodi:namedview
+     id="namedview5"
+     pagecolor="#ffffff"
+     bordercolor="#000000"
+     borderopacity="0.25"
+     inkscape:showpageshadow="2"
+     inkscape:pageopacity="0.0"
+     inkscape:pagecheckerboard="0"
+     inkscape:deskcolor="#d1d1d1"
+     inkscape:zoom="39.958333"
+     inkscape:cx="12"
+     inkscape:cy="12"
+     inkscape:window-width="2133"
+     inkscape:window-height="1168"
+     inkscape:window-x="0"
+     inkscape:window-y="0"
+     inkscape:window-maximized="1"
+     inkscape:current-layer="g5" />
+  <g
+     transform="translate(0,-1028.3622)"
+     id="g5"
+     style="display:inline">
+    <path
+       style="display:inline;fill:#e5e5e5;fill-opacity:1;stroke:none;stroke-width:1.21;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1"
+       d="M 1.1762252,11.511992 20.271116,2.9781022 V 18.118874 H 1.1762252 Z"
+       id="path9"
+       transform="translate(0,1028.3622)" />
+    <path
+       d="M 2.5384617,1030.9006 H 15.46154 v 12.9231 H 2.5384617 Z"
+       fill="#fce94f"
+       stroke="#c4a000"
+       stroke-linecap="round"
+       stroke-width="1.07692"
+       id="path3"
+       style="display:inline" />
+    <path
+       d="m 22.652743,1044.0577 -12.756464,-6.9791 5.477553,13.6014 2.180887,-3.5312 4.312159,4.7134 1.633122,-1.5913 -4.408599,-4.6683 3.561343,-1.5449 z"
+       style="display:inline;fill:#ffffff;fill-rule:evenodd;stroke:#000000;stroke-width:0.7;stroke-linecap:round;stroke-linejoin:round"
+       id="path5" />
+    <path
+       style="fill:#424242;fill-opacity:1;stroke:#424242;stroke-width:1.21;stroke-opacity:1;stroke-dasharray:4.84000015, 1.21000004;stroke-dashoffset:0"
+       d="M 0.86932117,11.063943 20.052472,2.4501349"
+       id="path6"
+       transform="translate(0,1028.3622)" />
+  </g>
+</svg>
diff --git a/src/app/3d/qgs3dmapcanvaswidget.cpp b/src/app/3d/qgs3dmapcanvaswidget.cpp
index 7f5ebbb4295d..d4a5dbcd8e85 100644
--- a/src/app/3d/qgs3dmapcanvaswidget.cpp
+++ b/src/app/3d/qgs3dmapcanvaswidget.cpp
@@ -103,8 +103,8 @@ Qgs3DMapCanvasWidget::Qgs3DMapCanvasWidget( const QString &name, bool isDocked )
   editingToolsButton->setPopupMode( QToolButton::ToolButtonPopupMode::InstantPopup );
   QAction *actionPointCloudChangeAttributeTool = mEditingToolsMenu->addAction( QIcon( QgsApplication::iconPath( QStringLiteral( "mActionSelectPolygon.svg" ) ) ), tr( "Polygon selector" ), this, &Qgs3DMapCanvasWidget::polygonTool );
   QAction *actionPaintBrush = mEditingToolsMenu->addAction( QIcon( QgsApplication::iconPath( QStringLiteral( "propertyicons/rendering.svg" ) ) ), tr( "Paint Brush Selector" ), this, &Qgs3DMapCanvasWidget::paintBrush );
-  QAction *actionAboveLineTool = mEditingToolsMenu->addAction( QIcon( QgsApplication::iconPath( QStringLiteral( "mActionArrowUp.svg" ) ) ), tr( "Above Line Selector" ), this, &Qgs3DMapCanvasWidget::aboveLineTool );
-  QAction *actionBelowLineTool = mEditingToolsMenu->addAction( QIcon( QgsApplication::iconPath( QStringLiteral( "mActionArrowDown.svg" ) ) ), tr( "Below Line Selector" ), this, &Qgs3DMapCanvasWidget::belowLineTool );
+  QAction *actionAboveLineTool = mEditingToolsMenu->addAction( QIcon( QgsApplication::iconPath( QStringLiteral( "mActionSelectAboveLine.svg" ) ) ), tr( "Above Line Selector" ), this, &Qgs3DMapCanvasWidget::aboveLineTool );
+  QAction *actionBelowLineTool = mEditingToolsMenu->addAction( QIcon( QgsApplication::iconPath( QStringLiteral( "mActionSelectBelowLine.svg" ) ) ), tr( "Below Line Selector" ), this, &Qgs3DMapCanvasWidget::belowLineTool );
 
   mEditingToolBar->addWidget( mPointCloudEditingToolbar );
   mPointCloudEditingToolbar->addWidget( new QLabel( tr( "Attribute" ) ) );