-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize excel data export and include missed properties #999
Conversation
…or-the-selected-species,specimen-and-analyte-in-the-aggregated-sample-metadata-sheet
…or-the-selected-species,specimen-and-analyte-in-the-aggregated-sample-metadata-sheet # Conflicts: # user-interface/src/main/bundles/dev.bundle # user-interface/src/main/java/life/qbic/datamanager/files/export/sample/TemplateService.java # user-interface/src/main/java/life/qbic/datamanager/files/structure/sample/EditColumn.java # user-interface/src/main/java/life/qbic/datamanager/files/structure/sample/RegisterColumn.java # user-interface/src/main/java/life/qbic/datamanager/importing/SampleInformationExtractor.java # user-interface/src/main/java/life/qbic/datamanager/importing/parser/MetadataConverter.java # user-interface/src/main/java/life/qbic/datamanager/templates/sample/SampleBatchRegistrationTemplate.java # user-interface/src/main/java/life/qbic/datamanager/templates/sample/SampleBatchUpdateTemplate.java # user-interface/src/main/java/life/qbic/datamanager/views/projects/project/samples/SampleInformationMain.java # user-interface/src/main/java/life/qbic/datamanager/views/projects/project/samples/registration/batch/EditSampleBatchDialog.java # user-interface/src/main/java/life/qbic/datamanager/views/projects/project/samples/registration/batch/RegisterSampleBatchDialog.java
@KochTobi looks to me that the PR does not fix the actual problem it was about to solve: ![]() sample metadata is still not showing the ontology CURIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what happened here, the PR is not in scope with the title.
I cant confirm that the actual issue has been resolved.
Are you sure you checked out the correct branch? For me it looks like this: |
yes you are right, apologies. Ping me, once you have the FileNameFormatter implemented, the remaining code base looks good to me |
…or-the-selected-species,specimen-and-analyte-in-the-aggregated-sample-metadata-sheet
@sven1103 ping |
…ies-for-the-selected-species,specimen-and-analyte-in-the-aggregated-sample-metadata-sheet' into feature-982/982-show-the-ontologies-for-the-selected-species,specimen-and-analyte-in-the-aggregated-sample-metadata-sheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KochTobi,
the download of measurement metadata does not produce the expected result.
For general recommendation:
the iso date readability can be improved by adding -
between the entries, like YYYY-MM-DD
_...
It is still valid ISO 8601, but improves readability quite a lot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed for sample metadata download and measurement metadata download!
Provides a common download behaviour for measurement registration, measurement edit, sample registration, sample edit and sample metadata download
Re-Implements the download of sample information to match other downloaded XLSX files.
Includes confounding variables in all sample related excel downloads.