Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer.json adjustments #3

Closed
aik099 opened this issue Jul 4, 2014 · 4 comments
Closed

Composer.json adjustments #3

aik099 opened this issue Jul 4, 2014 · 4 comments
Assignees
Milestone

Comments

@aik099
Copy link
Member

aik099 commented Jul 4, 2014

  1. change package name (the name key) to: qa-tools/behat-extension
  2. remove dependency to Mink ("behat/mink": "dev-master",), because MinkExtension already has it
  3. change qa-tools dependency ("aik099/qa-tools": "dev-master") to *@dev, because it's valid version format and it will automatically pickup release when it happens, while dev-master is fixed link to master branch
  4. not sure about "minimum-stability": "dev",, maybe it's not needed at all and better to specify @dev in required package version in project's own composer.json
  5. remove the repositories key, because qa-tools library is already published on packagist
  6. split autoload into autoload (for main code) and autoload-dev (for tests)
  7. fixed mixed use of tabs/spaces
  8. change dependency from aik099/qa-tools to qa-tools\qa-tools
@aik099 aik099 added this to the 1.0 milestone Jul 4, 2014
@evangelion1204
Copy link
Contributor

The "minimum-stability": "dev", seems to be needed for some dependencies of qa-tools\qa-tools, there are even more:

a-tools/qa-tools 1.0.x-dev requires mindplay/annotations dev-master -> no matching package found.
    - qa-tools/qa-tools dev-master requires mindplay/annotations dev-master -> no matching package found.

Maybe I should keep it or we need to fix it there or you already know what the problem is

@aik099
Copy link
Member Author

aik099 commented Jul 7, 2014

That's the Composer's trick. If it happens, that you rely on non-released version (in dev-master) or used dependencies, then you need to include them in your project's composer.json. That's why on QA-Tools installation instructions you not only need to include qa-tools/qa-tools but also mindplay/annotations, since otherwise you'll get same exception.

I bet you need to manually list dev versions of mink & drivers in project's composer.json or otherwise 1.5 versions will be used.

@evangelion1204
Copy link
Contributor

I think we can close it, was done with #8.

@aik099
Copy link
Member Author

aik099 commented Aug 22, 2014

Closing via 2e651b5

@aik099 aik099 closed this as completed Aug 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants