-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is actually under the Dask license? #118
Comments
Sorry for the late response, I thought I had answered this and realized today that was only in my head 😉 As far as the pyproject.toml, I wasn't aware more than one license could be specified but I'll be honest and say I didn't think of the best way to express the license in that file or the resulting sdist/wheel. Overall I'm not sure the proper way to handle the licensing for this project so any help would be much appreciated. I'm surprised I chose MIT for this project when dask uses BSD-3 but I guess it doesn't matter at the end of the day(?). Almost everything in this package originated in the dask project, but was manipulated to work standalone outside of dask. The documentation is also based on dask's documentation of its configuration system. Every once and a while new updates in dask will be migrated to this package. |
The license key is a valid SPDX expression, so you can use I guess it doesn't really matter which one is used for which file; I was just confused that the only license headers in files I could find were MIT even when they had comments saying they came from dask under BSD-3-Clause. It seems like making them all BSD would make sense? |
If I'm reading the BSD-3 license properly, the only thing it requires is the copyright notice at the top of the source and the LICENSE file (so the conditions and disclaimer are included). I've also heard way back that unless explicitly stated, source files probably don't even need license headers. I could just remove them in that case and make sure the LICENSE file(s) are distributed with source and binaries. |
The repo contains
LICENSE.txt
, which isMIT
, but alsoDASK_LICENSE.txt
, which isBSD-3-Clause
. However, thepyproject.toml
only saysMIT
, and all.py
files (except__init__.py
for some reason) have a header that isMIT
.So which files are actually BSD-3-Clause? And if there are any,
pyproject.toml
should mention this.The text was updated successfully, but these errors were encountered: