-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Loading torch-model-archiver arguments from YAML #780
Comments
@dhaniram-kshirsagar @harshbafna Any thoughts on this? |
@skat00sh Yes, it will be nice to have YAML/json as an alternative to command input. |
Thanks @dhaniram-kshirsagar! Will start working on it soon |
Hi @skat00sh let me know if you're still interested in working on this so we get something merged. This involves 4 steps
|
@msaroufim Sorry, I almost forgot about this issue! I'm back on it now, will finish it asap! Thanks for defining the steps! |
@msaroufim I think I should release it for now for someone else. With the academic workload this sem, I'm finding it a bit hard to find time for anything. Sorry that I took so long again to revert. I wished to mention 2 more things though:
|
Is your feature request related to a problem? Please describe.
torch-model-archiver
takes in a lot of params that makes it a hefty command line argumentDescribe the solution
Allowing all the param values to be parsed from a YAML file when
torch-model-archiver
is used with a--yaml
flag.It will also help automating creation of multiple
.mar
from different configurations.Describe alternatives solution
I've tried calling
torch-model-archiver
from a shell script with variableparams
and that works file as well. But I just wanted to bounce this idea off the community to see if it is something people could find useful.I'd be happy to work on it.
The text was updated successfully, but these errors were encountered: