Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup lock paths #329

Open
maximilize opened this issue May 28, 2015 · 2 comments
Open

Cleanup lock paths #329

maximilize opened this issue May 28, 2015 · 2 comments

Comments

@maximilize
Copy link

We are using the lock recipe for millions of objects so we have to create a unique lock name for each object. Since the lock recipe does not delete the path this will mess up zookeeper after a short time.

My suggestion is to have an option to try to delete the path after the lock is released. This can lead to race conditions between ensure_path and the ephemeral node creation so have to do more changes to the recipe.

What do you guys think? Is there another way we can prevent messing up zookeeper with our millions of different locks?

@harlowja
Copy link
Contributor

It seems fine with me, wanna do a PR?

@radix
Copy link
Contributor

radix commented Jul 2, 2015

btw this might be obsoleted by #334, depending on if you want to support older versions of ZK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants