Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit 'bun' for dependabot package-ecosystem #528

Closed
vorburger opened this issue Feb 18, 2025 · 3 comments
Closed

Permit 'bun' for dependabot package-ecosystem #528

vorburger opened this issue Feb 18, 2025 · 3 comments
Labels
upstream-schema-issue An issue with a schema or schema provider

Comments

@vorburger
Copy link

dependabot/dependabot-core#6528 has introduced https://bun.sh to https://github.com/dependabot; see also https://github.blog/changelog/2025-02-13-dependabot-version-updates-now-support-the-bun-package-manager-ga/.

With (this project) https://github.com/python-jsonschema/check-jsonschema rev: 0.31.1 using - package-ecosystem: "bun" in a .github/dependabot.yml causes:

Validate Dependabot Config (v2)..........................................Failed
- hook id: check-dependabot
- exit code: 1

Schema validation errors were encountered.
  .github/dependabot.yml::$.updates[3].package-ecosystem: 'bun' is not one of ['bundler', 'cargo', 'composer', 'devcontainers', 'docker', 'dotnet-sdk', 'elm', 'gitsubmodule', 'github-actions', 'gomod', 'gradle', 'maven', 'mix', 'npm', 'nuget', 'pip', 'pub', 'swift', 'terraform']

I'm guessing the schema for Dependabot might not be defined by this project, but imported? If you tell me where, I'm willing to try contributing a PR.

@vorburger
Copy link
Author

I'm guessing the schema for Dependabot might not be defined by this project, but imported? If you tell me where, I'm willing to try contributing a PR.

Looks like this comes from here:

"url": "https://json.schemastore.org/dependabot-2.0.json",

Indeed https://json.schemastore.org/dependabot-2.0.json does not contain bun. I'm guessing this would have to be added to https://github.com/SchemaStore/schemastore/blob/8ec0fdff4e37de16e4bf410a3250ac6a306e04a9/src/schemas/json/dependabot-2.0.json#L648...

SchemaStore/schemastore#4463 raised - let's see if they merge that.

vorburger added a commit to vorburger/enola that referenced this issue Feb 18, 2025
vorburger added a commit to enola-dev/enola that referenced this issue Feb 18, 2025
@sirosen sirosen added the upstream-schema-issue An issue with a schema or schema provider label Feb 19, 2025
@sirosen
Copy link
Member

sirosen commented Feb 19, 2025

Hi there! Yep, you've already figured out the situation. Schemas are vendored from schemastore (and some other places), so the way to get an update in is to get it altered upstream and then we can do an update+release here to get it updated.

Looks like your SchemaStore PR already merged! I'll put out a release tomorrow to get this rolled out.

I think the contributing doc doesn't say enough about the vendoring process, so I'll try to remember to come back to that and put in some text which hopefully can make this a bit easier for new contributors to pick up.

@sirosen
Copy link
Member

sirosen commented Feb 20, 2025

Okay, this should now be available in v0.31.2!

Thanks for contributing to schemastore. Let me know if you see any issues using it from here.

@sirosen sirosen closed this as completed Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream-schema-issue An issue with a schema or schema provider
Projects
None yet
Development

No branches or pull requests

2 participants