fix: use env filter properly #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently if we pass env filter in an array with the other layers it won't be executed first (to act as a filter). This change fixes that by explicitly adding it before.
ali-bahjati
force-pushed
the
fix/env-filter
branch
from
afb398d to
4004622
Compare
|
Even though I set RUST_LOG=info, the agent was still dumping logs including TRACE. This might have been the cause. |
|
@factec-kyle yeah that's right, this PR aims to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently if we pass env filter in an array with the other layers it won't be executed first (to act as a filter). This change fixes that by explicitly adding it before.