Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintuitive behavior using dmrgscf (block) and fcisolver attributes #1479

Closed
HehnLukas opened this issue Oct 21, 2022 · 1 comment
Closed

Comments

@HehnLukas
Copy link

If you want to change block settings, such as the maxM value, there are two ways to do so:
1.

mc = dmrgscf.DMRGSCF(mf,norb,nelec)
mc.fcisolver = dmrgscf.DMRGCI(mol)
mc.fcisolver.maxM = 50
mc.kernel()
mc = dmrgscf.DMRGSCF(mf,norb,nelec)
mc.fcisolver = dmrgscf.DMRGCI(mol,maxM = 50)
mc.kernel()

However, these lead to different behavior: method 1 only sets the maxM attribute, while leaving scheduleMaxMs = [200, 400, 800, 1000, 1000, 1000, 1000, 1000], which is the default. Method 2 also updates scheduleMaxMs according to the selected maxM: scheduleMaxMs = [50, 50, 50, 50, 50]

In my opinion, it makes much more sense for the method 2 behavior to always happen, but either way, it is not clear as a user whether you are updating just the one value or also the scheduler behavior.

@sunqm
Copy link
Collaborator

sunqm commented Mar 17, 2023

This problem will be solved in another repo pyscf/dmrgscf#9

@sunqm sunqm closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants