Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should shapely be added as an (optional?) dependency? #1470

Open
pmav99 opened this issue Jan 28, 2025 · 1 comment · May be fixed by #1471
Open

Should shapely be added as an (optional?) dependency? #1470

pmav99 opened this issue Jan 28, 2025 · 1 comment · May be fixed by #1471
Labels
bug dependencies Pull requests that update a dependency file

Comments

@pmav99
Copy link

pmav99 commented Jan 28, 2025

Some of the pyproj functionality requires shapely. E.g. Geod.geometry_area_perimeter. Nevertheless when you pip install pyproj, shapely does not get installed. I understand that most of the time when you install pyproj you will also install shapely or something else that will pull shapely, nevertheless, from a metadata point of view, shouldn't it be added at least as an optional dependency?

@pmav99 pmav99 added the bug label Jan 28, 2025
@snowman2
Copy link
Member

Yes, definitely. A MR would be appreciated.

@snowman2 snowman2 added the dependencies Pull requests that update a dependency file label Jan 28, 2025
pmav99 added a commit to pmav99/pyproj that referenced this issue Jan 29, 2025
pmav99 added a commit to pmav99/pyproj that referenced this issue Jan 29, 2025
pmav99 added a commit to pmav99/pyproj that referenced this issue Jan 29, 2025
@pmav99 pmav99 linked a pull request Jan 29, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants