Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔎 Move out logic for "preparing" sdists, from InstallRequirement #6622

Closed
pradyunsg opened this issue Jun 17, 2019 · 3 comments
Closed

🔎 Move out logic for "preparing" sdists, from InstallRequirement #6622

pradyunsg opened this issue Jun 17, 2019 · 3 comments
Labels
auto-locked Outdated issues that have been locked by automation type: refactor Refactoring code

Comments

@pradyunsg
Copy link
Member

pradyunsg commented Jun 17, 2019 •
edited
Loading

This would mostly involve moving prepare_metadata() and ensure_source_dir() being moved into SourceDistribution as it stands today.

I'll explore splitting it up into LegacySourceDistribution and SourceDistribution once all the logic and (state?) is in one place.
@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Jun 17, 2019
@pradyunsg pradyunsg added the type: refactor Refactoring code label Jun 17, 2019
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Jun 17, 2019
@pradyunsg
Copy link
Member Author

pradyunsg commented Jun 17, 2019 •
edited
Loading

Pinging @pypa/pip-committers here. Thoughts welcome on this. This is the next step in the refactor.

@pradyunsg pradyunsg mentioned this issue Jun 17, 2019
Open
@chrahunt
Copy link
Member

chrahunt commented Sep 4, 2019

I've submitted some PRs to clean this area up with more to come.

@pradyunsg pradyunsg changed the title 🔎 Move out logic for "preparing" sdists, from InstallRequirement to SourceDistribution 🔎 Move out logic for "preparing" sdists, from InstallRequirement Sep 19, 2019
@pradyunsg
Copy link
Member Author

pradyunsg commented Nov 7, 2019 •
edited
Loading

This is now done. We took a different route from what has been described in OP (see #6607 (comment)).

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrahunt @pradyunsg