Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude prior suffix from CLV model config #1428

Open
wd60622 opened this issue Jan 24, 2025 · 1 comment
Open

Exclude prior suffix from CLV model config #1428

wd60622 opened this issue Jan 24, 2025 · 1 comment
Labels
CLV good second issue Bit more involved but still doable for newcomers maintenance major API breaking changes model config request discussion

Comments

@wd60622
Copy link
Contributor

wd60622 commented Jan 24, 2025

The MMM and customer choice models don't have this suffix. All CLV models have this convention. Here is an example:

"alpha_prior": Prior("HalfFlat"),
"r_prior": Prior("HalfFlat"),
"phi_dropout_prior": Prior("Uniform", lower=0, upper=1),
"kappa_dropout_prior": Prior("Pareto", alpha=1, m=1),

I think the "prior" is implied in the context of the model so I find it a bit redundant. Then the variable drops the suffix in the model.

What are your thoughts @ColtAllen?

@ColtAllen ColtAllen added maintenance major API breaking changes model config good second issue Bit more involved but still doable for newcomers labels Jan 24, 2025
@ColtAllen
Copy link
Collaborator

I think this was done to distinguish between Prior and Posterior TensorVariables because the ModelBuilder prior/posterior methods were unsupported at the time. I'm in favor of standardized API conventions between MMM/CLV/CC, so let's get these variables renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV good second issue Bit more involved but still doable for newcomers maintenance major API breaking changes model config request discussion
Projects
None yet
Development

No branches or pull requests

2 participants