Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BLENDMODE_MUL to constants #3258

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add BLENDMODE_MUL to constants #3258

merged 1 commit into from
Dec 11, 2024

Conversation

yunline
Copy link
Contributor

@yunline yunline commented Dec 9, 2024

Fixes #3255.

@yunline yunline added the bugfix PR that fixes bug label Dec 9, 2024
@yunline yunline requested a review from a team as a code owner December 9, 2024 03:13
ankith26
ankith26 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@damusss damusss added the New API This pull request may need extra debate as it adds a new class or function to pygame label Dec 9, 2024
damusss
damusss approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to let someone else merge, but it looks good to me. I was also sure it existed before, and pygame.BLEND_RGB(a?)_MULT having the same value is just coincidence, this constant was clearly missing.

@ankith26 ankith26 added this to the 2.5.3 milestone Dec 11, 2024
@ankith26 ankith26 merged commit 8a7bbf2 into pygame-community:main Dec 11, 2024
25 checks passed
@yunline yunline deleted the yunline-BLENDMODE_MUL branch December 12, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
bugfix PR that fixes bug New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.

Missing pygame.BLENDMODE_MULT for the SDL Blendmodes
3 participants
@yunline @ankith26 @damusss